On 07/11/2016 01:48 PM, Andrey Utkin wrote:
> Thanks for review Hans!
>
> On Mon, Jul 11, 2016 at 07:58:38AM +0200, Hans Verkuil wrote:
>>> +" v4l2-ctl --device $dev --set-ctrl=video_gop_size=1; done\n"
>>
>> Replace $dev by /dev/videoX
>>
>> Wouldn't it make more sense to default to this? And sho
Thanks for review Hans!
On Mon, Jul 11, 2016 at 07:58:38AM +0200, Hans Verkuil wrote:
> > +" v4l2-ctl --device $dev --set-ctrl=video_gop_size=1; done\n"
>
> Replace $dev by /dev/videoX
>
> Wouldn't it make more sense to default to this? And show the warning only if
> P-frames are enabled?
I bel
On 07/11/2016, 07:58 AM, Hans Verkuil wrote:
>> +static char *artifacts_warning = "BEWARE OF KNOWN ISSUES WITH VIDEO
>> QUALITY\n"
>
> const char * const
Or even better, drop the extra space for pointer:
static const char artifacts_warning[] =
thanks,
--
js
suse labs
_
Hi Andrey,
Thanks for this driver. Some review comments below:
On 07/09/2016 09:46 PM, Andrey Utkin wrote:
> From: Andrey Utkin
>
>
> Changes in v3 since v2:
> - Kconfig: select VIDEOBUF2_DMA_CONTIG, not SG
> - drop i2c code as unused
> - Dropped num_buffers check in queue_setup as suggeste
