Re: [PATCH v2 4/6] staging: sm750fb: Remove unused function

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 10:59:41AM +, Lorenzo Stoakes wrote: > On 11 March 2015 at 10:57, Sudip Mukherjee wrote: > > but function prototype still remains in sm750_accel.h > > No it doesn't, v2 of patch 3 in the series no longer puts it there :) oops.. i am sorry.. i still had your previous pa

Re: [PATCH v2 4/6] staging: sm750fb: Remove unused function

2015-03-11 Thread Lorenzo Stoakes
On 11 March 2015 at 10:57, Sudip Mukherjee wrote: > but function prototype still remains in sm750_accel.h No it doesn't, v2 of patch 3 in the series no longer puts it there :) -- Lorenzo Stoakes https:/ljs.io ___ devel mailing list de...@linuxdriverpr

Re: [PATCH v2 4/6] staging: sm750fb: Remove unused function

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 10:45:48AM +, Lorenzo Stoakes wrote: > This patch removes the unused hw712_fillrect function. This patch fixes > the following sparse warning:- > > drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' > was not declared. Should it be static? >

[PATCH v2 4/6] staging: sm750fb: Remove unused function

2015-03-11 Thread Lorenzo Stoakes
This patch removes the unused hw712_fillrect function. This patch fixes the following sparse warning:- drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750_accel.c |