Re: [PATCH v2 4/5] staging: unisys: remove ERRDEV macros

2015-02-26 Thread Romer, Benjamin M
On Thu, 2015-02-26 at 20:37 +0300, Dan Carpenter wrote: > There is only one place which calls this ASSERT() macro. It should > probably be changed to: > > WARN_ON(!pw->is_scheduled); I can do that in a subsequent patch, but my intent was to remove the logging macros, not to fix th

Re: [PATCH v2 4/5] staging: unisys: remove ERRDEV macros

2015-02-26 Thread Dan Carpenter
On Thu, Feb 26, 2015 at 11:47:49AM -0500, Benjamin Romer wrote: > diff --git a/drivers/staging/unisys/include/timskmod.h > b/drivers/staging/unisys/include/timskmod.h > index 7ad65cc..c23cde5 100644 > --- a/drivers/staging/unisys/include/timskmod.h > +++ b/drivers/staging/unisys/include/timskmod.h

[PATCH v2 4/5] staging: unisys: remove ERRDEV macros

2015-02-26 Thread Benjamin Romer
Remove the LOGERR, LOGERRDEV, LOGERRDEVX, LOGERRNAME, LOGORDUMPERR macros from all the drivers. Signed-off-by: Benjamin Romer --- v2 - Fixed a mistake where some of the if statements had accidentally doubled tabs if the then clause was only one statement. drivers/staging/unisys/include/timskmod