Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function

2015-03-09 Thread Dan Carpenter
On Mon, Mar 09, 2015 at 06:25:03PM +0530, Sudip Mukherjee wrote: > Actually I thought, since this is a vendor crude driver there will be many > such changes, so if i can combine some changes together then atleast the > number of patches can be kept low and also i thought of clubbing these > chan

Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function

2015-03-09 Thread Sudip Mukherjee
On Mon, Mar 09, 2015 at 03:42:22PM +0300, Dan Carpenter wrote: > On Mon, Mar 09, 2015 at 01:05:06PM +0530, Sudip Mukherjee wrote: > > kbuild test robot reported that for microblaze-allyesconfig > > chan_to_field() and lynxfb_ops_set_par() were not defined. These two > > functions were defined under

Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function

2015-03-09 Thread Dan Carpenter
On Mon, Mar 09, 2015 at 01:05:06PM +0530, Sudip Mukherjee wrote: > kbuild test robot reported that for microblaze-allyesconfig > chan_to_field() and lynxfb_ops_set_par() were not defined. These two > functions were defined under CONFIG_PM, so for any archtecture if > CONFIG_PM is not defined we wil

[PATCH v2 4/4] staging: sm750fb: fix undeclared function

2015-03-09 Thread Sudip Mukherjee
kbuild test robot reported that for microblaze-allyesconfig chan_to_field() and lynxfb_ops_set_par() were not defined. These two functions were defined under CONFIG_PM, so for any archtecture if CONFIG_PM is not defined we will have this error. while moving the lynxfb_suspend() function some very