Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Sudip Mukherjee
On Thu, Sep 17, 2015 at 09:09:35AM +0530, Ronit Halder wrote: > On Wed, 2015-09-16 at 20:15 -0700, Greg KH wrote: > > On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > > > > I don't remember, that was many hundreds of patches ago, sorry. Try it > > yourself to see if I messed up. Perhaps

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
On Wed, 2015-09-16 at 20:15 -0700, Greg KH wrote: > On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > > Sorry for the ambiguity. > > I am talking about my second patch in the series. > > https://lkml.org/lkml/2015/9/15/293 > > > > > > None of the line edited in first patch haven't changed af

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Greg KH
On Thu, Sep 17, 2015 at 08:28:52AM +0530, roni wrote: > Sorry for the ambiguity. > I am talking about my second patch in the series. > https://lkml.org/lkml/2015/9/15/293 > > > > None of the line edited in first patch haven't changed after that. > > You applied the version 1 of the first patch in

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread roni
Sorry for the ambiguity. I am talking about my second patch in the series. https://lkml.org/lkml/2015/9/15/293 > > None of the line edited in first patch haven't changed after that. You applied the version 1 of the first patch in the series https://git.kernel.org/cgit/linux/kernel/git/gregkh/stag

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Sep 17, 2015 at 07:13:39AM +0530, Ronit Halder wrote: > Why not the second one? Second what? > None of the line edited in first patch haven't changed after that. I don't understand what you

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-16 Thread Ronit Halder
Why not the second one? None of the line edited in first patch haven't changed after that. On Tue, Sep 15, 2015 at 7:24 PM, Greg KH wrote: > On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote: >> This patch fixes the warning generated by sparse >> "Using plain integer as NULL pointer" b

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-15 Thread Greg KH
On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote: > This patch fixes the warning generated by sparse > "Using plain integer as NULL pointer" by using NULL > instead of zero. > > Signed-off-by: Ronit halder > --- > > v2: added a new patch in this patch series to fix the NULL compariso

[PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

2015-09-15 Thread Ronit Halder
This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder --- v2: added a new patch in this patch series to fix the NULL comparison style drivers/staging/wilc1000/coreconfigurator.c | 14 +++--- dri