Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Christian.Gromm
On Fr, 2019-03-29 at 16:50 +0300, Dan Carpenter wrote: > External E-Mail > > > Thanks, I feel like I understand better now. > > Sorry, I don't want to be a jerk and I'm not going to complain again > about this patchset if you resend it with the other stuff I mention > fixed. > > But to me it fe

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Dan Carpenter
Thanks, I feel like I understand better now. Sorry, I don't want to be a jerk and I'm not going to complain again about this patchset if you resend it with the other stuff I mention fixed. But to me it feels like the API could be improved slightly if you first created the adapter with a name and

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Christian.Gromm
On Fr, 2019-03-29 at 13:46 +0300, Dan Carpenter wrote: > External E-Mail > > > On Thu, Mar 28, 2019 at 02:17:32PM +0100, Christian Gromm wrote: > > > > +static int audio_create_sound_card(void) > > +{ > > + int ret; > > + struct sound_adapter *adpt; > > + > > + list_for_each_entry(adpt, &a

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Dan Carpenter
On Thu, Mar 28, 2019 at 02:17:32PM +0100, Christian Gromm wrote: > +static int audio_create_sound_card(void) > +{ > + int ret; > + struct sound_adapter *adpt; > + > + list_for_each_entry(adpt, &adpt_list, list) { > + if (!adpt->registered) > + goto adpt_a

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-29 Thread Christian.Gromm
On Do, 2019-03-28 at 16:56 +0300, Dan Carpenter wrote: > External E-Mail > > > On Thu, Mar 28, 2019 at 02:17:32PM +0100, Christian Gromm wrote: > > > > +static int audio_create_sound_card(void) > > +{ > > + int ret; > > + struct sound_adapter *adpt; > > + > > + list_for_each_entry(adpt, &a

Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-28 Thread Dan Carpenter
On Thu, Mar 28, 2019 at 02:17:32PM +0100, Christian Gromm wrote: > +static int audio_create_sound_card(void) > +{ > + int ret; > + struct sound_adapter *adpt; > + > + list_for_each_entry(adpt, &adpt_list, list) { > + if (!adpt->registered) > + goto adpt_a

[PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

2019-03-28 Thread Christian Gromm
This patch adapts the sound card management to the configfs changes. Signed-off-by: Christian Gromm --- v2: drivers/staging/most/sound/sound.c | 41 +- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/drivers/staging/most/sound/sound.c b/drive