Re: [PATCH v2 0/17] staging: qlge: Fix rx stall in case of allocation failures

2019-10-04 Thread Greg Kroah-Hartman
On Fri, Oct 04, 2019 at 06:15:45PM +0900, Benjamin Poirier wrote: > On 2019/10/04 10:19, Greg Kroah-Hartman wrote: > > On Fri, Sep 27, 2019 at 07:11:54PM +0900, Benjamin Poirier wrote: > [...] > > > > As this code got moved to staging with the goal to drop it from the > > tree, why are you working

Re: [PATCH v2 0/17] staging: qlge: Fix rx stall in case of allocation failures

2019-10-04 Thread Benjamin Poirier
On 2019/10/04 10:19, Greg Kroah-Hartman wrote: > On Fri, Sep 27, 2019 at 07:11:54PM +0900, Benjamin Poirier wrote: [...] > > As this code got moved to staging with the goal to drop it from the > tree, why are you working on fixing it up? Do you want it moved back > out of staging into the "real"

Re: [PATCH v2 0/17] staging: qlge: Fix rx stall in case of allocation failures

2019-10-04 Thread Greg Kroah-Hartman
On Fri, Sep 27, 2019 at 07:11:54PM +0900, Benjamin Poirier wrote: > qlge refills rx buffers from napi context. In case of allocation failure, > allocation will be retried the next time napi runs. If a receive queue runs > out of free buffers (possibly after subsequent allocation failures), it > dro

[PATCH v2 0/17] staging: qlge: Fix rx stall in case of allocation failures

2019-09-27 Thread Benjamin Poirier
qlge refills rx buffers from napi context. In case of allocation failure, allocation will be retried the next time napi runs. If a receive queue runs out of free buffers (possibly after subsequent allocation failures), it drops all traffic, no longer raises interrupts and napi is no longer schedule