Re: [PATCH v2] vme: change LM callback argument to void pointer

2016-07-07 Thread Martyn Welch
On 29/04/16 22:41, Aaron Sierra wrote: Make the location monitor callback function prototype more useful by changing the argument from an integer to a void pointer. All VME bridge drivers were simply passing the location monitor index (e.g. 0-3) as the argument to these callbacks. It is much m

Re: [PATCH v2] vme: change LM callback argument to void pointer

2016-05-25 Thread Martyn Welch
Sorry it's taken me so long to get to this, I've wanted to write some test code to prove this out to myself and I've been struggling to find the time. On 29/04/16 22:41, Aaron Sierra wrote: diff --git a/Documentation/vme_api.txt b/Documentation/vme_api.txt index ca5b827..4ca63a6 100644 ---

Re: [PATCH v2] vme: change LM callback argument to void pointer

2016-05-04 Thread Alessio Igor Bogani
Dan, Aaron, On 3 May 2016 at 15:18, Dan Carpenter wrote: > On Tue, May 03, 2016 at 02:52:54PM +0200, Alessio Igor Bogani wrote: [...] >> It would be great since we have a lot of VME drivers (for devices not >> for bridges) which we would like see mainlined. >> Unfortunately, considering the limit

Re: [PATCH v2] vme: change LM callback argument to void pointer

2016-05-03 Thread Aaron Sierra
- Original Message - > From: "Dan Carpenter" > To: "Alessio Igor Bogani" > Sent: Tuesday, May 3, 2016 8:18:38 AM > > On Tue, May 03, 2016 at 02:52:54PM +0200, Alessio Igor Bogani wrote: > > Dan, > > > > On 30 April 2016 at 12:16, Dan Carpenter wrote: > > > On Fri, Apr 29, 2016 at 04:41

Re: [PATCH v2] vme: change LM callback argument to void pointer

2016-05-03 Thread Dan Carpenter
On Tue, May 03, 2016 at 02:52:54PM +0200, Alessio Igor Bogani wrote: > Dan, > > On 30 April 2016 at 12:16, Dan Carpenter wrote: > > On Fri, Apr 29, 2016 at 04:41:02PM -0500, Aaron Sierra wrote: > >> There appear to be no in-kernel callers of vme_lm_attach (or > >> vme_lme_request for that matter)

Re: [PATCH v2] vme: change LM callback argument to void pointer

2016-05-03 Thread Alessio Igor Bogani
Dan, On 30 April 2016 at 12:16, Dan Carpenter wrote: > On Fri, Apr 29, 2016 at 04:41:02PM -0500, Aaron Sierra wrote: >> There appear to be no in-kernel callers of vme_lm_attach (or >> vme_lme_request for that matter), so this change only affects the VME >> subsystem and bridge drivers. > > Are we

Re: [PATCH v2] vme: change LM callback argument to void pointer

2016-05-02 Thread Aaron Sierra
- Original Message - > From: "Dan Carpenter" > Sent: Saturday, April 30, 2016 5:16:19 AM > > On Fri, Apr 29, 2016 at 04:41:02PM -0500, Aaron Sierra wrote: > > There appear to be no in-kernel callers of vme_lm_attach (or > > vme_lme_request for that matter), so this change only affects the

Re: [PATCH v2] vme: change LM callback argument to void pointer

2016-04-30 Thread Dan Carpenter
On Fri, Apr 29, 2016 at 04:41:02PM -0500, Aaron Sierra wrote: > There appear to be no in-kernel callers of vme_lm_attach (or > vme_lme_request for that matter), so this change only affects the VME > subsystem and bridge drivers. Are we planning to add in-kernel users soon? regards, dan carpenter

[PATCH v2] vme: change LM callback argument to void pointer

2016-04-29 Thread Aaron Sierra
Make the location monitor callback function prototype more useful by changing the argument from an integer to a void pointer. All VME bridge drivers were simply passing the location monitor index (e.g. 0-3) as the argument to these callbacks. It is much more useful to pass back a pointer to data t