Re: [PATCH v2] staging: vt6655: fix sparse warning for static declaration

2014-10-08 Thread Dan Carpenter
On Wed, Oct 08, 2014 at 06:53:02AM -0700, Greg Kroah-Hartman wrote: > On Thu, Oct 09, 2014 at 12:17:06AM +1100, Vladimir A. Nazarenko wrote: > > This patch fixes the following sparse warning: > > drivers/staging/vt6655/ioctl.c:44:12: warning: symbol 'wpa_Result' > > was not declared. Should it

Re: [PATCH v2] staging: vt6655: fix sparse warning for static declaration

2014-10-08 Thread Greg Kroah-Hartman
On Thu, Oct 09, 2014 at 12:17:06AM +1100, Vladimir A. Nazarenko wrote: > This patch fixes the following sparse warning: > drivers/staging/vt6655/ioctl.c:44:12: warning: symbol 'wpa_Result' > was not declared. Should it be static? > > There is no sense to set up all fields of wpa_Result to ze

[PATCH v2] staging: vt6655: fix sparse warning for static declaration

2014-10-08 Thread Vladimir A. Nazarenko
This patch fixes the following sparse warning: drivers/staging/vt6655/ioctl.c:44:12: warning: symbol 'wpa_Result' was not declared. Should it be static? There is no sense to set up all fields of wpa_Result to zero when interface set up (in device_open()), because wpa_Result is used only in