Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt

2017-03-13 Thread Radosław Pietrzyk
Understood 2017-03-13 12:19 GMT+01:00 Dan Carpenter : > On Mon, Mar 13, 2017 at 12:16:13PM +0100, Radosław Pietrzyk wrote: >> Ok I will. I just have thought that in general it might be helpful to >> have this possibility as DT is parsed for this option anyway. If you >> think it is not needed at a

Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt

2017-03-13 Thread Dan Carpenter
On Mon, Mar 13, 2017 at 12:16:13PM +0100, Radosław Pietrzyk wrote: > Ok I will. I just have thought that in general it might be helpful to > have this possibility as DT is parsed for this option anyway. If you > think it is not needed at all that why to bother parsing DT for this > option in the fi

Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt

2017-03-13 Thread Radosław Pietrzyk
Ok I will. I just have thought that in general it might be helpful to have this possibility as DT is parsed for this option anyway. If you think it is not needed at all that why to bother parsing DT for this option in the first place ? 2017-03-13 12:11 GMT+01:00 Dan Carpenter : > On Mon, Mar 13, 2

Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt

2017-03-13 Thread Dan Carpenter
On Mon, Mar 13, 2017 at 12:07:20PM +0100, Radosław Pietrzyk wrote: > I have and used with stm32 and fb_ili9341. First patch was shitty, my bad. > Could you resend with a patch description which says why you are doing this? "With stm32 and fb_ili9341 the monitor just sits there blinking because b

Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt

2017-03-13 Thread Radosław Pietrzyk
I have and used with stm32 and fb_ili9341. First patch was shitty, my bad. 2017-03-13 12:00 GMT+01:00 Dan Carpenter : > On Mon, Mar 13, 2017 at 11:28:45AM +0100, Radoslaw Pietrzyk wrote: >> Allows bpp to be set from dt >> > > Who does this affect in real life? You haven't tested it apparently so

Re: [PATCH v2] staging: fbtft: Allows bpp to be set from dt

2017-03-13 Thread Dan Carpenter
On Mon, Mar 13, 2017 at 11:28:45AM +0100, Radoslaw Pietrzyk wrote: > Allows bpp to be set from dt > Who does this affect in real life? You haven't tested it apparently so it's hard to say why you are doing this. regards, dan carpenter ___ devel maili

[PATCH v2] staging: fbtft: Allows bpp to be set from dt

2017-03-13 Thread Radoslaw Pietrzyk
Allows bpp to be set from dt Signed-off-by: Radoslaw Pietrzyk --- drivers/staging/fbtft/fbtft-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index 7c8af29..cb0c10d 100644 --- a/drivers/staging/fbtft/fbtft-core