Re: [PATCH v2] staging: esp8089: add new driver

2016-08-21 Thread Greg KH
On Tue, Jun 21, 2016 at 08:17:14AM -0700, Greg KH wrote: > On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote: > > The driver is only a working port of a badly written driver extracted from > > an old and vendor-specified kernel source. > > I cannot promise the code style (although I di

Re: [PATCH v2] staging: esp8089: add new driver

2016-06-21 Thread Greg KH
On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote: > The driver is only a working port of a badly written driver extracted from an > old and vendor-specified kernel source. > I cannot promise the code style (although I did indent -kr -i8). > I cannot also promise the effect. I don't u

Re: [PATCH v2] staging: esp8089: add new driver

2016-06-20 Thread Icenowy Zheng
The driver is only a working port of a badly written driver extracted from an old and vendor-specified kernel source. I cannot promise the code style (although I did indent -kr -i8). I cannot also promise the effect. 20.06.2016, 23:43, "Greg KH" : > On Sun, Jun 19, 2016 at 08:33:48PM +0800, Iceno

Re: [PATCH v2] staging: esp8089: add new driver

2016-06-20 Thread Greg KH
On Sun, Jun 19, 2016 at 08:33:48PM +0800, Icenowy Zheng wrote: > This commit adds Espressif ESP8089 driver, the SDIO version. > > ESP8089 is a 802.11b/g/n card with SDIO/SPI interface. It is usually used in > low-price tablets with Allwiner or RockChip SoCs. > > Signed-off-by: Icenowy Zheng Why