Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-16 Thread Mark Hounschell
On 03/15/2015 08:07 AM, Mark Hounschell wrote: On 03/14/2015 04:44 AM, Greg KH wrote: On Fri, Mar 13, 2015 at 04:55:55PM -0400, Mark Hounschell wrote: On 03/12/2015 12:14 PM, Giedrius Statkevičius wrote: On 2015.03.12 12:08, Greg KH wrote: On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius St

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-15 Thread Greg KH
On Sun, Mar 15, 2015 at 08:07:09AM -0400, Mark Hounschell wrote: > >>Greg, while I'm here, how can we get Digi firmware into the kernel firmware > >>tree? The dgap card is useless without it and I suspect the dgnc is as well. > > > >Submit a patch to the linux-firmware git tree with the firmware in

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-15 Thread Mark Hounschell
On 03/14/2015 04:44 AM, Greg KH wrote: On Fri, Mar 13, 2015 at 04:55:55PM -0400, Mark Hounschell wrote: On 03/12/2015 12:14 PM, Giedrius Statkevičius wrote: On 2015.03.12 12:08, Greg KH wrote: On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: Remove BOARD_FAILED and don't

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-14 Thread Greg KH
On Fri, Mar 13, 2015 at 04:55:55PM -0400, Mark Hounschell wrote: > On 03/12/2015 12:14 PM, Giedrius Statkevičius wrote: > >On 2015.03.12 12:08, Greg KH wrote: > >>On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: > >>>Remove BOARD_FAILED and don't save dgnc_boards which failed

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-13 Thread Mark Hounschell
On 03/12/2015 12:14 PM, Giedrius Statkevičius wrote: On 2015.03.12 12:08, Greg KH wrote: On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: Remove BOARD_FAILED and don't save dgnc_boards which failed to initialize. Assign the result of kzalloc() to brd in dgnc_found_board()

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-13 Thread Giedrius Statkevičius
Hi Greg, On 2015.03.12 12:08, Greg KH wrote: > On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: >> Remove BOARD_FAILED and don't save dgnc_boards which failed to >> initialize. >> >> Assign the result of kzalloc() to brd in dgnc_found_board() and only put >> it in the dgnc_Bo

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-12 Thread Giedrius Statkevičius
On 2015.03.12 12:08, Greg KH wrote: > On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: >> Remove BOARD_FAILED and don't save dgnc_boards which failed to >> initialize. >> >> Assign the result of kzalloc() to brd in dgnc_found_board() and only put >> it in the dgnc_Board[] if i

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-12 Thread Dan Carpenter
On Thu, Mar 12, 2015 at 11:08:49AM +0100, Greg KH wrote: > I really want to see this whole "static list of boards/cards" go away. Yes, but I feel like this is a step in that direction. It just deletes dead code, it doesn't add anything. regards, dan carpenter ___

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-12 Thread Greg KH
On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: > Remove BOARD_FAILED and don't save dgnc_boards which failed to > initialize. > > Assign the result of kzalloc() to brd in dgnc_found_board() and only put > it in the dgnc_Board[] if it successfully initializes. Also, remove >

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-10 Thread Dan Carpenter
On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: > Remove BOARD_FAILED and don't save dgnc_boards which failed to > initialize. > > Assign the result of kzalloc() to brd in dgnc_found_board() and only put > it in the dgnc_Board[] if it successfully initializes. Also, remove >

[PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-09 Thread Giedrius Statkevičius
Remove BOARD_FAILED and don't save dgnc_boards which failed to initialize. Assign the result of kzalloc() to brd in dgnc_found_board() and only put it in the dgnc_Board[] if it successfully initializes. Also, remove BOARD_FAILED enum and all ifs that check for it. Finally, remove one final place w