Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joe Perches
On Sun, 2014-04-06 at 14:00 -0500, Joel Pelaez Jorge wrote: > El 06/04/14 13:49, Joe Perches escribió: > > On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote: [] > >> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c [] > >> -static struct iw_statistics *r8192_get_wireless_stats(struc

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Greg Kroah-Hartman
On Sun, Apr 06, 2014 at 03:43:42PM -0500, Joel Pelaez Jorge wrote: > El 06/04/14 15:26, Greg Kroah-Hartman escribió: > > On Sun, Apr 06, 2014 at 02:12:44PM -0500, Joel Pelaez Jorge wrote: > >> El 06/04/14 14:01, Greg Kroah-Hartman escribió: > >>> On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelae

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
El 06/04/14 15:26, Greg Kroah-Hartman escribió: > On Sun, Apr 06, 2014 at 02:12:44PM -0500, Joel Pelaez Jorge wrote: >> El 06/04/14 14:01, Greg Kroah-Hartman escribió: >>> On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote: Fix a sparse warning, non static symbol is no declared

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Greg Kroah-Hartman
On Sun, Apr 06, 2014 at 02:12:44PM -0500, Joel Pelaez Jorge wrote: > El 06/04/14 14:01, Greg Kroah-Hartman escribió: > > On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote: > >> Fix a sparse warning, non static symbol is no declared as such. > >> And fix a conflict with static functi

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joe Perches
On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote: > Fix a sparse warning, non static symbol is no declared as such. > And fix a conflict with static function declared extern to include > rtl_wx.h header. > > drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: > symbol 'r8192_wx_

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
El 06/04/14 14:01, Greg Kroah-Hartman escribió: On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote: Fix a sparse warning, non static symbol is no declared as such. And fix a conflict with static function declared extern to include rtl_wx.h header. drivers/staging/rtl8192e/rtl8192

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
El 06/04/14 13:49, Joe Perches escribió: On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote: Fix a sparse warning, non static symbol is no declared as such. And fix a conflict with static function declared extern to include rtl_wx.h header. drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:132

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Greg Kroah-Hartman
On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote: > Fix a sparse warning, non static symbol is no declared as such. > And fix a conflict with static function declared extern to include > rtl_wx.h header. > > drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: > symbol 'r8

[PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
Fix a sparse warning, non static symbol is no declared as such. And fix a conflict with static function declared extern to include rtl_wx.h header. drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: symbol 'r8192_wx_handlers_def' was not declared. Should it be static? Signed-off-by: Jo