Re: [PATCH v2] Staging: greybus: usb: Fixed a coding style error

2019-04-01 Thread Dan Carpenter
On Mon, Apr 01, 2019 at 10:22:08AM -0400, Will Cunningham wrote: > Line was >80 characters. > > Signed-off-by: Will Cunningham > --- > Changes in v2: > - Created a tmp variable to shorten line length. > --- > drivers/staging/greybus/usb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletio

Re: [PATCH v2] Staging: greybus: usb: Fixed a coding style error

2019-04-01 Thread Alex Elder
On 4/1/19 9:22 AM, Will Cunningham wrote: > Line was >80 characters. This looks fine, but "tmp" is not a meaningful name. That argument to gb_connection_create() is a cport id, so "cport_id" would be a much better name for the variable. It seems picky, but details like this make the code much mor

[PATCH v2] Staging: greybus: usb: Fixed a coding style error

2019-04-01 Thread Will Cunningham
Line was >80 characters. Signed-off-by: Will Cunningham --- Changes in v2: - Created a tmp variable to shorten line length. --- drivers/staging/greybus/usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/usb.c b/drivers/staging/greybus/usb.c i