Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-13 Thread Octavian Purdila
On Fri, Dec 13, 2013 at 7:14 AM, Arve Hjønnevåg wrote: > On Thu, Dec 12, 2013 at 12:45 AM, Octavian Purdila > wrote: >> On Thu, Dec 12, 2013 at 1:00 AM, Arve Hjønnevåg wrote: >>> On Wed, Dec 11, 2013 at 10:10 AM, Octavian Purdila >>> wrote: On Wed, Dec 11, 2013 at 5:21 AM, Arve Hjønnevåg

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-12 Thread Arve Hjønnevåg
On Thu, Dec 12, 2013 at 12:45 AM, Octavian Purdila wrote: > On Thu, Dec 12, 2013 at 1:00 AM, Arve Hjønnevåg wrote: >> On Wed, Dec 11, 2013 at 10:10 AM, Octavian Purdila >> wrote: >>> On Wed, Dec 11, 2013 at 5:21 AM, Arve Hjønnevåg wrote: Assuming you are talking about a kernel compat

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-12 Thread Octavian Purdila
On Thu, Dec 12, 2013 at 1:00 AM, Arve Hjønnevåg wrote: > On Wed, Dec 11, 2013 at 10:10 AM, Octavian Purdila > wrote: >> On Wed, Dec 11, 2013 at 5:21 AM, Arve Hjønnevåg wrote: >>> >>> Assuming you are talking about a kernel compat layer that translates >>> the flat_binder_object structs as they p

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-11 Thread Arve Hjønnevåg
On Wed, Dec 11, 2013 at 10:10 AM, Octavian Purdila wrote: > On Wed, Dec 11, 2013 at 5:21 AM, Arve Hjønnevåg wrote: >> >> Assuming you are talking about a kernel compat layer that translates >> the flat_binder_object structs as they pass between 32 bit and 64 bit >> processes, that will not always

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-11 Thread Octavian Purdila
On Wed, Dec 11, 2013 at 5:21 AM, Arve Hjønnevåg wrote: > > Assuming you are talking about a kernel compat layer that translates > the flat_binder_object structs as they pass between 32 bit and 64 bit > processes, that will not always work. The data portion of the message > sometimes contain size v

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-10 Thread Arve Hjønnevåg
On Mon, Dec 9, 2013 at 7:01 PM, Octavian Purdila wrote: > On Thu, Dec 5, 2013 at 4:02 AM, Arve Hjønnevåg wrote: >> On Wed, Dec 4, 2013 at 2:02 PM, Greg KH wrote: >>> On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: On Wed, Dec 4, 2013 at 1:43 PM, Greg KH wrote: > On Wed, D

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-09 Thread Octavian Purdila
On Thu, Dec 5, 2013 at 4:02 AM, Arve Hjønnevåg wrote: > On Wed, Dec 4, 2013 at 2:02 PM, Greg KH wrote: >> On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: >>> On Wed, Dec 4, 2013 at 1:43 PM, Greg KH wrote: >>> > On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: >>> >> On W

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-05 Thread Greg KH
On Thu, Dec 05, 2013 at 06:31:25PM +, Serban Constantinescu wrote: > Hi all, > > Thanks for your feedback! Sadly enough, being in a different > time-zone, is not useful. > > Sorry for the confusion related to why is this patch needed or not. I > should highlight a bit more what is the patch e

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-05 Thread Serban Constantinescu
Hi all, Thanks for your feedback! Sadly enough, being in a different time-zone, is not useful. Sorry for the confusion related to why is this patch needed or not. I should highlight a bit more what is the patch enabling and what would be the different alternatives, at least from my perspectiv

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Arve Hjønnevåg
On Wed, Dec 4, 2013 at 2:02 PM, Greg KH wrote: > On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: >> On Wed, Dec 4, 2013 at 1:43 PM, Greg KH wrote: >> > On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: >> >> On Wed, Dec 4, 2013 at 10:35 AM, Greg KH >> >> wrote: >> >> >>

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread One Thousand Gnomes
> None of this (the patch series or the original code) is mine. My Sorry mistraced the attribution sequence > question was more of a general one on designing ioctls, as well as > concerns with changing the existing 32-bit api. I think in general my advice would be: If its already been screwed

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Colin Cross
On Wed, Dec 4, 2013 at 4:02 PM, Greg KH wrote: > On Wed, Dec 04, 2013 at 02:22:13PM -0800, Colin Cross wrote: >> On Wed, Dec 4, 2013 at 2:02 PM, Greg KH wrote: >> > On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: >> >> On Wed, Dec 4, 2013 at 1:43 PM, Greg KH >> >> wrote: >> >> > On

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Greg KH
On Wed, Dec 04, 2013 at 02:22:13PM -0800, Colin Cross wrote: > On Wed, Dec 4, 2013 at 2:02 PM, Greg KH wrote: > > On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: > >> On Wed, Dec 4, 2013 at 1:43 PM, Greg KH wrote: > >> > On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: >

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread One Thousand Gnomes
On Wed, 4 Dec 2013 10:35:54 -0800 Greg KH wrote: > On Wed, Dec 04, 2013 at 06:09:41PM +, Serban Constantinescu wrote: > > +#define size_helper(x) ({ \ > > + size_t __size; \ > > + if (!is_com

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Colin Cross
On Wed, Dec 4, 2013 at 3:21 PM, One Thousand Gnomes wrote: > On Wed, 4 Dec 2013 10:35:54 -0800 > Greg KH wrote: > >> On Wed, Dec 04, 2013 at 06:09:41PM +, Serban Constantinescu wrote: >> > +#define size_helper(x) ({ \ >> > + size_t __size;

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Colin Cross
On Wed, Dec 4, 2013 at 2:02 PM, Greg KH wrote: > On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: >> On Wed, Dec 4, 2013 at 1:43 PM, Greg KH wrote: >> > On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: >> >> On Wed, Dec 4, 2013 at 10:35 AM, Greg KH >> >> wrote: >> >> >>

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Greg KH
On Wed, Dec 04, 2013 at 01:55:34PM -0800, Colin Cross wrote: > On Wed, Dec 4, 2013 at 1:43 PM, Greg KH wrote: > > On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: > >> On Wed, Dec 4, 2013 at 10:35 AM, Greg KH > >> wrote: > >> > >> > >> > And finally, is this all really needed? Why

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Colin Cross
On Wed, Dec 4, 2013 at 1:43 PM, Greg KH wrote: > On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: >> On Wed, Dec 4, 2013 at 10:35 AM, Greg KH wrote: >> >> >> > And finally, is this all really needed? Why not just fix the structures >> > to be "correct", and then fix userspace to use

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Greg KH
On Wed, Dec 04, 2013 at 12:46:42PM -0800, Colin Cross wrote: > On Wed, Dec 4, 2013 at 10:35 AM, Greg KH wrote: > > > > And finally, is this all really needed? Why not just fix the structures > > to be "correct", and then fix userspace to use the correct structures as > > well, thereby not needi

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Colin Cross
On Wed, Dec 4, 2013 at 10:35 AM, Greg KH wrote: > And finally, is this all really needed? Why not just fix the structures > to be "correct", and then fix userspace to use the correct structures as > well, thereby not needing a compat layer at all? Some of the binder ioctls take userspace point

Re: [PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Greg KH
On Wed, Dec 04, 2013 at 06:09:41PM +, Serban Constantinescu wrote: > +#define size_helper(x) ({\ > + size_t __size; \ > + if (!is_compat_task())

[PATCH v1 9/9] staging: android: binder: Add binder compat layer

2013-12-04 Thread Serban Constantinescu
This patch adds support for 32bit userspace running on 64bit kernels. All the changes done in this patch have been tested on 32bit and 64bit systems. Signed-off-by: Serban Constantinescu --- drivers/staging/android/binder.c | 355 +- 1 file changed, 353 inser