On Sun, Sep 27, 2015 at 09:37:08PM -0700, Anish Bhatt wrote:
> If you mean -Woverflow, then that's a gcc warning, not a static checker
> warning.
Yes, I know. GCC doesn't warn for me. What are you doing different.
It is a stupid warning. It would be better to fix GCC instead.
regards,
dan ca
On Fri, Sep 25, 2015 at 10:47 PM, Dan Carpenter
wrote:
> On Fri, Sep 25, 2015 at 09:14:29AM -0700, Anish Bhatt wrote:
>> On Fri, Sep 25, 2015 at 3:50 AM, Dan Carpenter
>> wrote:
>> > On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote:
>> >> @@ -1672,11 +1673,11 @@ static int wilc_wlan_s
On Fri, Sep 25, 2015 at 09:14:29AM -0700, Anish Bhatt wrote:
> On Fri, Sep 25, 2015 at 3:50 AM, Dan Carpenter
> wrote:
> > On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote:
> >> @@ -1672,11 +1673,11 @@ static int wilc_wlan_stop(void)
> >> }
> >>
> >> } while (timeou
On Fri, Sep 25, 2015 at 3:50 AM, Dan Carpenter wrote:
> On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote:
>> @@ -1672,11 +1673,11 @@ static int wilc_wlan_stop(void)
>> }
>>
>> } while (timeout);
>> - reg = ((1 << 0) | (1 << 1) | (1 << 2) | (1 << 3) | (1 << 8) |
>
On Fri, Sep 25, 2015 at 12:45:17AM -0700, Anish Bhatt wrote:
> @@ -1672,11 +1673,11 @@ static int wilc_wlan_stop(void)
> }
>
> } while (timeout);
> - reg = ((1 << 0) | (1 << 1) | (1 << 2) | (1 << 3) | (1 << 8) |
> -(1 << 9) | (1 << 26) | (1 << 29) | (1 << 30) |
Replace (1 << x) by BIT(x) as recommended by
checkpatch.pl
Signed-off-by: Anish Bhatt
---
drivers/staging/wilc1000/host_interface.c | 4 +-
drivers/staging/wilc1000/host_interface.h | 38 +++
drivers/staging/wilc1000/linux_wlan_common.h | 8 ++--
drivers/staging/wilc1000/w
