Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-30 Thread Richard Weinberger
@aepfle.de; jasow...@redhat.com; driverdev- >> de...@linuxdriverproject.org; LKML ; >> net...@vger.kernel.org >> Subject: Re: [PATCH net-next] hyperv: Add handler for >> RNDIS_STATUS_NETWORK_CHANGE event >> >> Haiyang Zhang writes: >> >>>> -Ori

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-30 Thread Haiyang Zhang
ect.org; LKML ; > net...@vger.kernel.org > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > Haiyang Zhang writes: > > >> -Original Message- > >> From: Richard Weinberger [mailto:richard.weinber...@gmail.com] > >

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-30 Thread Vitaly Kuznetsov
vger.kernel.org; jasow...@redhat.com; >> driverdev-devel@linuxdriverproject.org; LKML > ker...@vger.kernel.org> >> Subject: Re: [PATCH net-next] hyperv: Add handler for >> RNDIS_STATUS_NETWORK_CHANGE event >> >> On Mon, Jun 23, 2014 at 10:10 PM, David Miller >&g

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-29 Thread Haiyang Zhang
> driverdev-devel@linuxdriverproject.org; LKML ker...@vger.kernel.org> > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > On Mon, Jun 23, 2014 at 10:10 PM, David Miller > wrote: > > From: Haiyang Zhang > > Date: Mon, 23 Jun 2014 1

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-28 Thread Haiyang Zhang
.com; driverdev-devel@linuxdriverproject.org; LKML > > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > On Mon, Jun 23, 2014 at 10:10 PM, David Miller > wrote: > > From: Haiyang Zhang > > Date: Mon, 23 Jun 2014 16:09:59 + >

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2015-10-27 Thread Richard Weinberger
On Mon, Jun 23, 2014 at 10:10 PM, David Miller wrote: > From: Haiyang Zhang > Date: Mon, 23 Jun 2014 16:09:59 + > >> So, what's the equivalent or similar command to "network restart" on SLES12? >> Could >> you update the command line for the usermodehelper when porting this patch >> to SLES

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-26 Thread Haiyang Zhang
; da...@davemloft.net > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > On Mon, Jun 23, Haiyang Zhang wrote: > > > Yes, there is a link down/up event from the host, we currently call > > netif_carrier_off() / netif_carrier_on(

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-26 Thread Olaf Hering
On Mon, Jun 23, Haiyang Zhang wrote: > Yes, there is a link down/up event from the host, we currently call > netif_carrier_off() > / netif_carrier_on() with these events. Will hotplug scripts be triggered by > netif_carrier_off/on? Where are the scripts located at (SLES)? In /etc/sysconfig/net

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Haiyang Zhang
er...@vger.kernel.org > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > From: Haiyang Zhang > Date: Mon, 23 Jun 2014 16:09:59 + > > > So, what's the equivalent or similar command to "network restart" on > >

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread David Miller
From: Greg KH Date: Mon, 23 Jun 2014 12:29:11 -0400 > Given that this change will fail on all future distro releases, and > almost all of the community distros today, I don't see how this is > acceptable at all. Nor would it be any better if you switch to a > systemd command line script as well.

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread David Miller
From: Haiyang Zhang Date: Mon, 23 Jun 2014 16:09:59 + > So, what's the equivalent or similar command to "network restart" on SLES12? > Could > you update the command line for the usermodehelper when porting this patch to > SLES > 12? No, you are not going to keep the usermodehelper invocat

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread David Miller
From: Olaf Hering Date: Mon, 23 Jun 2014 15:17:23 +0200 > On Mon, Jun 23, Haiyang Zhang wrote: > >> > I think its reasonable to expect guest config changes on this new kind >> > of host. Would a link-down/link-up event work? I'm sure it will, there >> > is enough code floating around in the gues

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Haiyang Zhang
vemloft.net > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > On Mon, Jun 23, 2014 at 04:09:59PM +, Haiyang Zhang wrote: > > > > > > > -Original Message- > > > From: Olaf Hering [mailto:o...@aepfle.

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Haiyang Zhang
vemloft.net > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > On Mon, Jun 23, Haiyang Zhang wrote: > > > I have tried some possibilities, like IF_OPER_DORMANT then IF_OPER_UP > > with > > netdev_state_change() etc. b

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Greg KH
sow...@redhat.com; driverdev- > > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; > > da...@davemloft.net > > Subject: Re: [PATCH net-next] hyperv: Add handler for > > RNDIS_STATUS_NETWORK_CHANGE event > > > > On Mon, Jun 23, Haiyang Zhang wrote: > &

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Olaf Hering
On Mon, Jun 23, Haiyang Zhang wrote: > I have tried some possibilities, like IF_OPER_DORMANT then IF_OPER_UP with > netdev_state_change() etc. but not able to trigger DHCP review. I will look > at this > further... Is there a link down/up event anyway? If the interface is configured to "on hotp

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Haiyang Zhang
vemloft.net > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > On Mon, Jun 23, Haiyang Zhang wrote: > > > > I think its reasonable to expect guest config changes on this new > > > kind of host. Would a link-down/link-

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Olaf Hering
On Mon, Jun 23, Haiyang Zhang wrote: > > I think its reasonable to expect guest config changes on this new kind > > of host. Would a link-down/link-up event work? I'm sure it will, there > > is enough code floating around in the guests which handles cable unplug. > > Do you mean netif_carrier_off

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Haiyang Zhang
vemloft.net > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > On Fri, Jun 20, Haiyang Zhang wrote: > > > This command ("/etc/init.d/network restart") exists on our supported > distros > > currently. We will

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-23 Thread Olaf Hering
On Fri, Jun 20, Haiyang Zhang wrote: > This command ("/etc/init.d/network restart") exists on our supported distros > currently. We will also look into some better ways to refresh the network for > the distros without this command. I have tried setting IF_OPER_DORMANT then > IF_OPER_UP, but not w

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-20 Thread Haiyang Zhang
.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > On Thu, Jun 19, 2014 at 06:34:36PM -0700, Haiyang Zhang wrote: > > @@ -589,7 +590,19 @@ void netvsc_linkstatus_callback(struct hv_device > *devic

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-20 Thread Haiyang Zhang
vemloft.net > Subject: Re: [PATCH net-next] hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event > > On Fri, Jun 20, 2014 at 06:57:04AM +0200, Olaf Hering wrote: > > On Thu, Jun 19, Haiyang Zhang wrote: > > > > > The RNDIS_STATUS_NETWORK_CHANGE event is receiv

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-20 Thread Dan Carpenter
On Thu, Jun 19, 2014 at 06:34:36PM -0700, Haiyang Zhang wrote: > @@ -589,7 +590,19 @@ void netvsc_linkstatus_callback(struct hv_device > *device_obj, > net_device = hv_get_drvdata(device_obj); > rdev = net_device->extension; > > - rdev->link_state = status != 1; > + switch (i

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread Greg KH
On Fri, Jun 20, 2014 at 06:57:04AM +0200, Olaf Hering wrote: > On Thu, Jun 19, Haiyang Zhang wrote: > > > The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host > > sleep or hibernation. We refresh network at this time. > > > + char *argv[] = { "/etc/init.d/network", "restart"

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread Olaf Hering
On Thu, Jun 19, Haiyang Zhang wrote: > The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host > sleep or hibernation. We refresh network at this time. > + char *argv[] = { "/etc/init.d/network", "restart", NULL }; What happens if that file does not exist? Dead network in th

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread David Miller
From: Haiyang Zhang Date: Thu, 19 Jun 2014 18:34:36 -0700 > The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host > sleep or hibernation. We refresh network at this time. > MS-TFS: 135162 > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks.

[PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

2014-06-19 Thread Haiyang Zhang
The RNDIS_STATUS_NETWORK_CHANGE event is received after the Hyper-V host sleep or hibernation. We refresh network at this time. MS-TFS: 135162 Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h |3 ++- drivers/net/hyperv/netvsc_drv.c | 30 +