Re: [PATCH V3 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

2014-12-15 Thread Jeremiah Mahler
Andy, On Mon, Dec 15, 2014 at 03:47:04PM +, Andy Whitcroft wrote: > On Sun, Dec 14, 2014 at 11:59:19PM -0800, Jeremiah Mahler wrote: [...] > > The calculation appears identical to my reading, the original form was: > > next_gpadl_handle = atomic_read(&vmbus_connection.next_gpadl_handle); >

Re: [PATCH V3 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

2014-12-15 Thread Andy Whitcroft
> Sent: Wednesday, December 10, 2014 6:10 PM > > > To: KY Srinivasan > > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > > > jasow...@redhat.com; mc...@ipxe.org > >

Re: [PATCH V3 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

2014-12-14 Thread Jeremiah Mahler
re...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > > jasow...@redhat.com; mc...@ipxe.org > > Subject: Re: [PATCH V3 1/1] Drivers: hv: vmbus: Fix a bug in > > vmbus_establish_gpadl() > > > > K

RE: [PATCH V3 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

2014-12-14 Thread KY Srinivasan
nical.com; > jasow...@redhat.com; mc...@ipxe.org > Subject: Re: [PATCH V3 1/1] Drivers: hv: vmbus: Fix a bug in > vmbus_establish_gpadl() > > K. Y. Srinivasan, > > On Wed, Dec 10, 2014 at 05:13:00PM -0800, K. Y. Srinivasan wrote: > > Correctly compute the local (gpadl) handle. >

Re: [PATCH V3 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

2014-12-10 Thread Jeremiah Mahler
K. Y. Srinivasan, On Wed, Dec 10, 2014 at 05:13:00PM -0800, K. Y. Srinivasan wrote: > Correctly compute the local (gpadl) handle. This description is still too sparse for me. How was it computed before and why was this incorrect? Pretend like you are trying to explain your patch to someone who

[PATCH V3 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

2014-12-10 Thread K. Y. Srinivasan
Correctly compute the local (gpadl) handle. I would like to thank Michael Brown for seeing this bug. Signed-off-by: K. Y. Srinivasan Reported-by: Michael Brown --- Changes in V2: Added the Reported-by tag. Changes in V3: Cleaned up the commit log. drivers/hv/channel.c |4 ++-- 1 files ch