Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

2014-07-14 Thread Greg KH
On Mon, Jul 14, 2014 at 07:01:37PM +0200, Peter Senna Tschudin wrote: > > I'm not trying to push my changes over the rules. I'm trying to > understand the problem, to avoid creating similar noise in the future. > > > Now I understand that the problem with the series of 4 patches is that > the su

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

2014-07-14 Thread Dan Carpenter
On Mon, Jul 14, 2014 at 07:01:37PM +0200, Peter Senna Tschudin wrote: > > I'm not trying to push my changes over the rules. I'm trying to > understand the problem, to avoid creating similar noise in the future. > > > Now I understand that the problem with the series of 4 patches is that > the su

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

2014-07-14 Thread Peter Senna Tschudin
I'm not trying to push my changes over the rules. I'm trying to understand the problem, to avoid creating similar noise in the future. Now I understand that the problem with the series of 4 patches is that the subject is the same on the 4 patches. Having the same subject in 4 patches is not good

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

2014-07-14 Thread Dan Carpenter
Since you're going to redo this patch anyway, I may as well give you the normal feedback for these kinds of patches. > >From 69cd87aca39730c0578592d1296b738f7f223f29 Mon Sep 17 00:00:00 2001 > From: Peter Senna Tschudin > Date: Mon, 14 Jul 2014 10:28:42 +0200 > Subject: [PATCH V3] staging: vt6556

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

2014-07-14 Thread Peter Senna Tschudin
On Mon, Jul 14, 2014 at 2:58 PM, Greg KH wrote: > On Mon, Jul 14, 2014 at 10:59:32AM +0200, Peter Senna Tschudin wrote: >> On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote: >> > On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote: >> > > This patch cleanup coding style issu

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

2014-07-14 Thread Greg KH
On Mon, Jul 14, 2014 at 10:59:32AM +0200, Peter Senna Tschudin wrote: > On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote: > > On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote: > > > This patch cleanup coding style issues reported by checkpatch. > > > > > > Tested by comp

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

2014-07-14 Thread Peter Senna Tschudin
On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote: > On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote: > > This patch cleanup coding style issues reported by checkpatch. > > > > Tested by compilation only. > > > > Signed-off-by: Peter Senna Tschudin > > --- > > Cahnges

Re: [PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

2014-07-13 Thread Greg KH
On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote: > This patch cleanup coding style issues reported by checkpatch. > > Tested by compilation only. > > Signed-off-by: Peter Senna Tschudin > --- > Cahnges from V1: > - Sent all patches in a series Why did you forget the other

[PATCH V2 1/4] staging: vt6556: Cleanup coding style issues

2014-07-13 Thread Peter Senna Tschudin
This patch cleanup coding style issues reported by checkpatch. Tested by compilation only. Signed-off-by: Peter Senna Tschudin --- Cahnges from V1: - Sent all patches in a series Made against latest staging-next. drivers/staging/vt6656/baseband.c | 28 1 file cha