On Tue, Feb 25, 2014 at 02:35:39PM -0500, Mark Hounschell wrote:
> On 02/25/2014 01:40 PM, Mark Hounschell wrote:
>
> >
> >>>+struct dgap_port {
> >>>+struct tty_port port;
> >>>+};
> >>
> >>Do you really need a wrapping structure here?
> >>
> >
> >I may be incorrect, but I think so. I will in
On 02/25/2014 01:40 PM, Mark Hounschell wrote:
+struct dgap_port {
+struct tty_port port;
+};
Do you really need a wrapping structure here?
I may be incorrect, but I think so. I will investigate this further
before I make a patch.
It looks to me like this is how it should be done.
On 02/25/2014 11:48 AM, Greg KH wrote:
On Tue, Feb 25, 2014 at 10:56:22AM -0500, Mark Hounschell wrote:
When opening a port the dgap driver OOPs with a message:
tty_init_dev: driver does not set tty->port... will crash the kernel... fix the
driver... etc...
Then I have to reboot the box.
I t
On Tue, Feb 25, 2014 at 10:56:22AM -0500, Mark Hounschell wrote:
> When opening a port the dgap driver OOPs with a message:
>
> tty_init_dev: driver does not set tty->port... will crash the kernel... fix
> the driver... etc...
>
> Then I have to reboot the box.
>
> I think before too much more
When opening a port the dgap driver OOPs with a message:
tty_init_dev: driver does not set tty->port... will crash the kernel... fix the
driver... etc...
Then I have to reboot the box.
I think before too much more work is done on this driver (by me anyway),
it should at least be in a usable st
