Re: [PATCH RFC] staging: ks7010: remove custom Michael MIC implementation

2017-03-31 Thread Tobin C. Harding
On Thu, Mar 30, 2017 at 10:16:05PM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 15:47 +1100, Tobin C. Harding wrote: > > ks7010 currently uses a custom implementation of the Michael MIC > > algorithm. The kernel has an implementation of this algorithm > > already, we should use it. > > ok, tr

Re: [PATCH RFC] staging: ks7010: remove custom Michael MIC implementation

2017-03-30 Thread Joe Perches
On Fri, 2017-03-31 at 15:47 +1100, Tobin C. Harding wrote: > ks7010 currently uses a custom implementation of the Michael MIC > algorithm. The kernel has an implementation of this algorithm > already, we should use it. ok, trivia: Do please run your patch through checkpatch and fix a few style ni

[PATCH RFC] staging: ks7010: remove custom Michael MIC implementation

2017-03-30 Thread Tobin C. Harding
ks7010 currently uses a custom implementation of the Michael MIC algorithm. The kernel has an implementation of this algorithm already, we should use it. Remove the custom implementation. Implement helper functions that call the in-tree implementation through the crypto API. Update the makefile. R