On Wed, Aug 20, 2014 at 08:25:45PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon wrote:
>
> > - bool done = true;
> > + int count = 0;
> > + int limit = budget;
> > + bool not_done = false;
>
> Don't use negative variables. Better to keep the original
On Wed, Aug 20, 2014 at 08:25:01PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon wrote:
>
> >
> > + if (budget > MAX_PACKETS_HANDLED)
> > + limit = MAX_PACKETS_HANDLED;
>
> Why this artificial restriction?
Hi Stephen, thanks for the review.
It'
On Wed, 20 Aug 2014 23:17:58 +0100
Mark Einon wrote:
>
> + if (budget > MAX_PACKETS_HANDLED)
> + limit = MAX_PACKETS_HANDLED;
Why this artificial restriction?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxd
On Wed, 20 Aug 2014 23:17:58 +0100
Mark Einon wrote:
> - bool done = true;
> + int count = 0;
> + int limit = budget;
> + bool not_done = false;
Don't use negative variables. Better to keep the original done variable.
___
devel mailing
This implements NAPI support for et131x by:
-adding a napi_struct to the private adapter struct
-changing netfif_rx_skb() call to netif_receive_skb()
-changing et131x_handle_recv_interrupt() to et131x_handle_recv_pkts()
and taking a budget allocation.
-changing et131x_handle_send_interrupt() to e
