Re: [PATCH 7/9] staging: panel: Refactor LCD init code

2014-11-18 Thread Willy Tarreau
On Tue, Nov 18, 2014 at 10:51:08PM +0100, Mariusz Gorski wrote: > On Tue, Nov 18, 2014 at 10:23:26PM +0100, Willy Tarreau wrote: > > On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote: > > > Rework lcd_init method to make it a little bit more clear about > > > the precedence of the para

Re: [PATCH 7/9] staging: panel: Refactor LCD init code

2014-11-18 Thread Mariusz Gorski
On Tue, Nov 18, 2014 at 10:23:26PM +0100, Willy Tarreau wrote: > On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote: > > Rework lcd_init method to make it a little bit more clear about > > the precedence of the params, move LCD geometry and pins layout > > to the LCD struct and thus mak

Re: [PATCH 7/9] staging: panel: Refactor LCD init code

2014-11-18 Thread Willy Tarreau
On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote: > Rework lcd_init method to make it a little bit more clear about > the precedence of the params, move LCD geometry and pins layout > to the LCD struct and thus make the LCD-related module params > effectively read-only. > > Signed-of

[PATCH 7/9] staging: panel: Refactor LCD init code

2014-11-18 Thread Mariusz Gorski
Rework lcd_init method to make it a little bit more clear about the precedence of the params, move LCD geometry and pins layout to the LCD struct and thus make the LCD-related module params effectively read-only. Signed-off-by: Mariusz Gorski --- drivers/staging/panel/panel.c | 304 +