Re: [PATCH 7/8] staging: sm7xxfb: move mode table

2015-06-17 Thread Sudip Mukherjee
On Wed, Jun 17, 2015 at 01:20:34AM -0700, Joe Perches wrote: > On Wed, 2015-06-17 at 13:45 +0530, Sudip Mukherjee wrote: > > On Tue, Jun 16, 2015 at 10:33:57AM -0700, Joe Perches wrote: > > > On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > > > > move vgamode table from the header file t

Re: [PATCH 7/8] staging: sm7xxfb: move mode table

2015-06-17 Thread Joe Perches
On Wed, 2015-06-17 at 13:45 +0530, Sudip Mukherjee wrote: > On Tue, Jun 16, 2015 at 10:33:57AM -0700, Joe Perches wrote: > > On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > > > move vgamode table from the header file to the C file and mark it > > > as const. > > > > The slightly odd in

Re: [PATCH 7/8] staging: sm7xxfb: move mode table

2015-06-17 Thread Sudip Mukherjee
On Tue, Jun 16, 2015 at 10:33:57AM -0700, Joe Perches wrote: > On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > > move vgamode table from the header file to the C file and mark it > > as const. > > The slightly odd indentation could be fixed here too. Ok. I am sending v2. But if I am re

Re: [PATCH 7/8] staging: sm7xxfb: move mode table

2015-06-16 Thread Joe Perches
On Tue, 2015-06-16 at 19:12 +0530, Sudip Mukherjee wrote: > move vgamode table from the header file to the C file and mark it > as const. The slightly odd indentation could be fixed here too. > +static const struct ModeInit vgamode[] = { > + { > + /* mode#0: 640 x 480 16Bpp 60Hz */ >

[PATCH 7/8] staging: sm7xxfb: move mode table

2015-06-16 Thread Sudip Mukherjee
move vgamode table from the header file to the C file and mark it as const. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xx.h | 660 -- drivers/staging/sm7xxfb/sm7xxfb.c | 660 ++ 2 files changed, 660 inse