Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-19 Thread Jonathan Cameron
. "Jürgen Beisert" wrote: >Hi Jonathan, > >On Monday 16 September 2013 17:30:32 Jonathan Cameron wrote: >> >On Sunday 15 September 2013 12:56:25 Jonathan ,,, wrote: >> >> On 09/11/13 09:18, Juergen Beisert wrote: >> >> > For battery driven systems it is a very bad idea to collect the >> >> > touc

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-19 Thread Jürgen Beisert
Hi Jonathan, On Monday 16 September 2013 17:30:32 Jonathan Cameron wrote: > >On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: > >> On 09/11/13 09:18, Juergen Beisert wrote: > >> > For battery driven systems it is a very bad idea to collect the > >> > touchscreen data within a kernel bu

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-17 Thread Jürgen Beisert
Hi Dmitry, On Monday 16 September 2013 17:28:46 Dmitry Torokhov wrote: > [...] > > > static int mxs_lradc_ts_register(struct mxs_lradc *lradc) > > > @@ -641,6 +1056,7 @@ static void mxs_lradc_ts_unregister(struct > > > mxs_lradc *lradc) > > > > > > cancel_work_sync(&lradc->ts_work); > > > > > >

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Jonathan Cameron
"Jürgen Beisert" wrote: >Hi Jonathan, > >On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: >> On 09/11/13 09:18, Juergen Beisert wrote: >> > For battery driven systems it is a very bad idea to collect the >> > touchscreen data within a kernel busy loop. >> > >> > This change uses the

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Dmitry Torokhov
On Sun, Sep 15, 2013 at 11:56:25AM +0100, Jonathan Cameron wrote: > On 09/11/13 09:18, Juergen Beisert wrote: > > For battery driven systems it is a very bad idea to collect the touchscreen > > data within a kernel busy loop. > > > > This change uses the features of the hardware to delay and accum

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Marek Vasut
Dear Jürgen Beisert, > Hi Marek, > > On Monday 16 September 2013 16:23:48 Marek Vasut wrote: > > > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: > > > > On 09/11/13 09:18, Juergen Beisert wrote: > > > > > For battery driven systems it is a very bad idea to collect the > > > > > tou

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Jürgen Beisert
Hi Marek, On Monday 16 September 2013 16:23:48 Marek Vasut wrote: > > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: > > > On 09/11/13 09:18, Juergen Beisert wrote: > > > > For battery driven systems it is a very bad idea to collect the > > > > touchscreen data within a kernel busy l

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Marek Vasut
Dear Jürgen Beisert, > Hi Jonathan, > > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: > > On 09/11/13 09:18, Juergen Beisert wrote: > > > For battery driven systems it is a very bad idea to collect the > > > touchscreen data within a kernel busy loop. > > > > > > This change uses

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Jürgen Beisert
Hi Jonathan, On Monday 16 September 2013 10:10:22 Jürgen Beisert wrote: > [...] > > While this driver is placed in IIO within staging at the moment, these > > changes are definitely input related. Hence I have cc'd Dmitry and the > > input list. > > > > I am personaly a little uncomfortable that

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Jürgen Beisert
Hi Jonathan, On Sunday 15 September 2013 18:10:18 Jonathan Cameron wrote: > On 09/15/13 11:56, Jonathan Cameron wrote: > > On 09/11/13 09:18, Juergen Beisert wrote: > >> For battery driven systems it is a very bad idea to collect the > >> touchscreen data within a kernel busy loop. > >> > >> This

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-16 Thread Jürgen Beisert
Hi Jonathan, On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: > On 09/11/13 09:18, Juergen Beisert wrote: > > For battery driven systems it is a very bad idea to collect the > > touchscreen data within a kernel busy loop. > > > > This change uses the features of the hardware to delay a

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-15 Thread Jonathan Cameron
On 09/15/13 11:56, Jonathan Cameron wrote: > On 09/11/13 09:18, Juergen Beisert wrote: >> For battery driven systems it is a very bad idea to collect the touchscreen >> data within a kernel busy loop. >> >> This change uses the features of the hardware to delay and accumulate >> samples in >> hard

Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-15 Thread Jonathan Cameron
On 09/11/13 09:18, Juergen Beisert wrote: > For battery driven systems it is a very bad idea to collect the touchscreen > data within a kernel busy loop. > > This change uses the features of the hardware to delay and accumulate samples > in > hardware to avoid a high interrupt and CPU load. > >

[PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

2013-09-11 Thread Juergen Beisert
For battery driven systems it is a very bad idea to collect the touchscreen data within a kernel busy loop. This change uses the features of the hardware to delay and accumulate samples in hardware to avoid a high interrupt and CPU load. Note: this is only tested on an i.MX23 SoC yet. Signed-off