Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-11 Thread Dan Carpenter
On Fri, Feb 09, 2018 at 12:39:18PM +1100, NeilBrown wrote: > On Tue, Aug 16 2016, James Simmons wrote: > > > > > +static inline bool > > +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md > > *lsm2) > > +{ > > + int idx; > > + > > + if (lsm1->lsm_md_magic != lsm2->lsm_m

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-11 Thread Oleg Drokin
> On Feb 11, 2018, at 6:44 PM, NeilBrown wrote: > > On Thu, Feb 08 2018, Oleg Drokin wrote: >> >> Certain things that sound useless (like the debug subsystem in Lustre) >> is very useful when you have a 10k nodes in a cluster and need to selectively >> pull stuff from a run to debug a complicat

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-11 Thread Oleg Drokin
> On Feb 11, 2018, at 6:50 PM, NeilBrown wrote: > > Maybe - as you suggest in another email - it is due to some > client/server incompatibility. I guess it is unavoidable with an fs > like lustre to have incompatible protocol changes. Is there any > mechanism for detecting the version of other

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-11 Thread NeilBrown
On Sat, Feb 10 2018, James Simmons wrote: >> > On Feb 8, 2018, at 10:10 PM, NeilBrown wrote: >> > >> > On Thu, Feb 08 2018, Oleg Drokin wrote: >> > >> >>> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: >> >>> >> >>> On Tue, Aug 16 2016, James Simmons wrote: >> >> >> >> my that’s an old patch >

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-11 Thread NeilBrown
On Thu, Feb 08 2018, Oleg Drokin wrote: >> On Feb 8, 2018, at 10:10 PM, NeilBrown wrote: >> >> On Thu, Feb 08 2018, Oleg Drokin wrote: >> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: On Tue, Aug 16 2016, James Simmons wrote: >>> >>> my that’s an old patch >>> >> ... >>>

Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-10 Thread James Simmons
> > +static inline bool > > +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md > > *lsm2) > > +{ > > + int idx; > > + > > + if (lsm1->lsm_md_magic != lsm2->lsm_md_magic || > > + lsm1->lsm_md_stripe_count != lsm2->lsm_md_stripe_count || > > + lsm1->lsm_md_maste

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-10 Thread James Simmons
> > On Feb 8, 2018, at 10:10 PM, NeilBrown wrote: > > > > On Thu, Feb 08 2018, Oleg Drokin wrote: > > > >>> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: > >>> > >>> On Tue, Aug 16 2016, James Simmons wrote: > >> > >> my that’s an old patch > >> > >>> > > ... > >>> > >>> Whoever converted

Re: [lustre-devel] [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-08 Thread Oleg Drokin
> On Feb 8, 2018, at 10:10 PM, NeilBrown wrote: > > On Thu, Feb 08 2018, Oleg Drokin wrote: > >>> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: >>> >>> On Tue, Aug 16 2016, James Simmons wrote: >> >> my that’s an old patch >> >>> > ... >>> >>> Whoever converted it to "!strcmp()" inverted t

Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-08 Thread NeilBrown
On Thu, Feb 08 2018, Oleg Drokin wrote: >> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: >> >> On Tue, Aug 16 2016, James Simmons wrote: > > my that’s an old patch > >> ... >> >> Whoever converted it to "!strcmp()" inverted the condition. This is a >> perfect example of why I absolutely *loath

Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-08 Thread Oleg Drokin
> On Feb 8, 2018, at 8:39 PM, NeilBrown wrote: > > On Tue, Aug 16 2016, James Simmons wrote: my that’s an old patch > >> >> +static inline bool >> +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md >> *lsm2) >> +{ >> +int idx; >> + >> +if (lsm1->lsm_md_magic !=

Re: [PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2018-02-08 Thread NeilBrown
On Tue, Aug 16 2016, James Simmons wrote: > > +static inline bool > +lsm_md_eq(const struct lmv_stripe_md *lsm1, const struct lmv_stripe_md *lsm2) > +{ > + int idx; > + > + if (lsm1->lsm_md_magic != lsm2->lsm_md_magic || > + lsm1->lsm_md_stripe_count != lsm2->lsm_md_stripe_count

[PATCH 41/80] staging: lustre: lmv: separate master object with master stripe

2016-08-16 Thread James Simmons
From: wang di Separate master stripe with master object, so 1. stripeEA only exists on master object. 2. sub-stripe object will be inserted into master object as sub-directory, and it can get the master object by "..". By this, it will remove those specilities for stripe0 in LMV and LOD. And als