Re: [PATCH 4/9] staging: wilc1000: free memory allocated in add wep key functions

2018-03-26 Thread Ajay Singh
Hi Dan, On Mon, 26 Mar 2018 11:17:48 +0300 Dan Carpenter wrote: > On Fri, Mar 23, 2018 at 08:38:53PM +0530, Ajay Singh wrote: > We should "return result;" here otherwise we'll hang when we > wait_for_completion(). This is the sort of bug why I always encourage > people to keep the error path a

Re: [PATCH 4/9] staging: wilc1000: free memory allocated in add wep key functions

2018-03-26 Thread Dan Carpenter
On Fri, Mar 23, 2018 at 08:38:53PM +0530, Ajay Singh wrote: > Free memory allocated for wep key when command enqueue is failed. > > Signed-off-by: Ajay Singh > --- > drivers/staging/wilc1000/host_interface.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/dri

[PATCH 4/9] staging: wilc1000: free memory allocated in add wep key functions

2018-03-23 Thread Ajay Singh
Free memory allocated for wep key when command enqueue is failed. Signed-off-by: Ajay Singh --- drivers/staging/wilc1000/host_interface.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_inte