Re: [Outreachy kernel] [PATCH 4/6] staging: Drop useless initialisation

2017-02-21 Thread Julia Lawall
> Also, note that the above semantic patch is not completely safe, > because > the code could be, eg: > > int a = 0; > a = a + 1; > > In that case, the initialization of a would be needed.  You > should check > each case for this issue. > > > I have c

Re: [Outreachy kernel] [PATCH 4/6] staging: Drop useless initialisation

2017-02-21 Thread Julia Lawall
On Tue, 21 Feb 2017, simran singhal wrote: > Removed initialisation of a varible if it is immediately reassigned. varible -> variable > > Changes were made using Coccinelle. > > @@ > type T; > constant C; > expression e; > identifier i; > @@ > > T i > - = C > ; > i = e; This is a big patch, a

[PATCH 4/6] staging: Drop useless initialisation

2017-02-21 Thread simran singhal
Removed initialisation of a varible if it is immediately reassigned. Changes were made using Coccinelle. @@ type T; constant C; expression e; identifier i; @@ T i - = C ; i = e; Signed-off-by: simran singhal --- drivers/staging/android/ion/ion_heap.c | 2 +- drivers/staging/gdm72