Re: [PATCH 4/4] staging: ozwpan: Create deferred work to destroy PD object.

2013-08-23 Thread Rupesh Gujare
On 23/08/13 10:05, Dan Carpenter wrote: On Thu, Aug 22, 2013 at 05:38:51PM +0100, Rupesh Gujare wrote: +/*-- * Context: softirq-serialized */ Don't resend the patch, but these comments are not in kernel style. It'

Re: [PATCH 4/4] staging: ozwpan: Create deferred work to destroy PD object.

2013-08-23 Thread Rupesh Gujare
On 22/08/13 18:45, Sergei Shtylyov wrote: +void oz_pd_destroy(struct oz_pd *pd) +{ +int ret; + +if (hrtimer_active(&pd->timeout)) +hrtimer_cancel(&pd->timeout); +if (hrtimer_active(&pd->heartbeat)) +hrtimer_cancel(&pd->heartbeat); + +memset(&pd->workitem, 0, sizeof

Re: [PATCH 4/4] staging: ozwpan: Create deferred work to destroy PD object.

2013-08-23 Thread Dan Carpenter
On Thu, Aug 22, 2013 at 05:38:51PM +0100, Rupesh Gujare wrote: > +/*-- > * Context: softirq-serialized > */ Don't resend the patch, but these comments are not in kernel style. It's explained in Documentation/kernel-doc

Re: [PATCH 4/4] staging: ozwpan: Create deferred work to destroy PD object.

2013-08-22 Thread Sergei Shtylyov
Hello. On 08/22/2013 08:38 PM, Rupesh Gujare wrote: Currently we call oz_pd_destroy() from softirq context, where we try to destroy relevant data structures, as well we kill a tasklet which always result in following kernel warning. [12279.262194] Attempt to kill tasklet from interrupt [1227

[PATCH 4/4] staging: ozwpan: Create deferred work to destroy PD object.

2013-08-22 Thread Rupesh Gujare
Currently we call oz_pd_destroy() from softirq context, where we try to destroy relevant data structures, as well we kill a tasklet which always result in following kernel warning. [12279.262194] Attempt to kill tasklet from interrupt [12279.262202] Attempt to kill tasklet from interrupt This pat