Re: [PATCH 4/4] staging: greybus: audio: Ensure proper byte order

2017-01-16 Thread Vaibhav Agarwal
On Mon, Jan 16, 2017 at 4:17 PM, Dan Carpenter wrote: > On Sat, Jan 14, 2017 at 11:17:07PM +0530, Vaibhav Agarwal wrote: >> @@ -656,13 +660,13 @@ static int gbaudio_tplg_create_enum_kctl(struct >> gbaudio_module_info *gb, >> gb_enum = &ctl->info.value.enumerated; >> >> /* since count=

Re: [PATCH 4/4] staging: greybus: audio: Ensure proper byte order

2017-01-16 Thread Dan Carpenter
On Sat, Jan 14, 2017 at 11:17:07PM +0530, Vaibhav Agarwal wrote: > @@ -656,13 +660,13 @@ static int gbaudio_tplg_create_enum_kctl(struct > gbaudio_module_info *gb, > gb_enum = &ctl->info.value.enumerated; > > /* since count=1, and reg is dummy */ > - gbe->max = gb_enum->items; >

[PATCH 4/4] staging: greybus: audio: Ensure proper byte order

2017-01-14 Thread Vaibhav Agarwal
From: Vaibhav Agarwal Proper byte order was completely disregarded for multi byte data shared between AP and module (and APB1). Fix this. Signed-off-by: Vaibhav Agarwal Signed-off-by: Vaibhav Agarwal --- drivers/staging/greybus/audio_module.c | 2 +- drivers/staging/greybus/audio_topology.