Re: [PATCH 32/44] staging: unisys: Move channel creation up the stack

2015-05-18 Thread Dan Carpenter
On Mon, May 18, 2015 at 11:20:27AM -0400, Don Zickus wrote: > What might be confusing you is the bus_info = bus_find() command above. Yes. You are right. This was where I got confused. Was in too much of a hurry. Sorry about that. regards, dan carpenter _

Re: [PATCH 32/44] staging: unisys: Move channel creation up the stack

2015-05-18 Thread Don Zickus
On Sat, May 16, 2015 at 02:38:57PM +0300, Dan Carpenter wrote: > On Wed, May 13, 2015 at 01:22:26PM -0400, Benjamin Romer wrote: > > --- a/drivers/staging/unisys/visorbus/visorchipset.c > > +++ b/drivers/staging/unisys/visorbus/visorchipset.c > > @@ -1197,6 +1197,7 @@ bus_create(struct controlvm_me

Re: [PATCH 32/44] staging: unisys: Move channel creation up the stack

2015-05-16 Thread Dan Carpenter
On Wed, May 13, 2015 at 01:22:26PM -0400, Benjamin Romer wrote: > --- a/drivers/staging/unisys/visorbus/visorchipset.c > +++ b/drivers/staging/unisys/visorbus/visorchipset.c > @@ -1197,6 +1197,7 @@ bus_create(struct controlvm_message *inmsg) > u32 bus_no = cmd->create_bus.bus_no; > int

[PATCH 32/44] staging: unisys: Move channel creation up the stack

2015-05-13 Thread Benjamin Romer
From: Don Zickus Instead of creating a channel struct to temporarily hold the channel info and passing it through multiple functions until the device is created, just create the channel from the start. This allows us to remove the channel_info struct. I noticed 'chan_info.addr_type' was not bei