Re: [PATCH 3/6] staging: rtl8188eu: remove goto label

2015-07-17 Thread Sudip Mukherjee
On Fri, Jul 17, 2015 at 02:47:55PM +0300, Dan Carpenter wrote: > On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote: > > On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > > > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > > > By checking for the suc

Re: [PATCH 3/6] staging: rtl8188eu: remove goto label

2015-07-17 Thread Dan Carpenter
On Fri, Jul 17, 2015 at 04:55:12PM +0530, Sudip Mukherjee wrote: > On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > > By checking for the success of kzalloc we were able to remove the goto > > > label thus making

Re: [PATCH 3/6] staging: rtl8188eu: remove goto label

2015-07-17 Thread Sudip Mukherjee
On Fri, Jul 17, 2015 at 02:03:48PM +0300, Dan Carpenter wrote: > On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > > By checking for the success of kzalloc we were able to remove the goto > > label thus making the code more readable. > > > > No... You've just changed error handl

Re: [PATCH 3/6] staging: rtl8188eu: remove goto label

2015-07-17 Thread Dan Carpenter
On Thu, Jul 16, 2015 at 04:58:09PM +0530, Sudip Mukherjee wrote: > By checking for the success of kzalloc we were able to remove the goto > label thus making the code more readable. > No... You've just changed error handling to success handling and added some new indent levels and made a tangled

[PATCH 3/6] staging: rtl8188eu: remove goto label

2015-07-16 Thread Sudip Mukherjee
By checking for the success of kzalloc we were able to remove the goto label thus making the code more readable. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188e