Re: [PATCH 3/6] rtl8188eu: declare internal function as static

2016-08-28 Thread Luca Ceresoli
Dear Andy, thanks for your review. On 28/08/2016 14:28, Andy Shevchenko wrote: > On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote: > > Put here few words _why_ you are doing this. I'm doing it because this function is only used inside rtw_recv.c. Which is quite logical, since it's a timer

Re: [PATCH 3/6] rtl8188eu: declare internal function as static

2016-08-28 Thread Andy Shevchenko
On Sat, 2016-08-27 at 14:40 +0200, Luca Ceresoli wrote: Put here few words _why_ you are doing this. Perhaps, add output of sparse static analyzer. > Signed-off-by: Luca Ceresoli > Cc: Greg Kroah-Hartman > Cc: Bhaktipriya Shridhar > Cc: Andy Shevchenko > Cc: Geliang Tang > Cc: Jakub Sitnicki

[PATCH 3/6] rtl8188eu: declare internal function as static

2016-08-27 Thread Luca Ceresoli
Signed-off-by: Luca Ceresoli Cc: Greg Kroah-Hartman Cc: Bhaktipriya Shridhar Cc: Andy Shevchenko Cc: Geliang Tang Cc: Jakub Sitnicki Cc: Ivan Safonov Cc: Kyle Kuffermann Cc: linux-ker...@vger.kernel.org --- drivers/staging/rtl8188eu/core/rtw_recv.c | 4 ++-- 1 file changed, 2 insertions(+)