Re: [PATCH 3/6] Staging/iio/adc/touchscreen/MXS: simplify register access

2013-09-16 Thread Jonathan Cameron
On 09/16/13 09:17, Jürgen Beisert wrote: > Hi Jonathan, > > On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote: >> [...] >>> +static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg) >>> +{ >>> + writel(val, lradc->base + reg + STMP_OFFSET_REG_SET); >>> +} >>> + >>> +sta

Re: [PATCH 3/6] Staging/iio/adc/touchscreen/MXS: simplify register access

2013-09-16 Thread Marek Vasut
Dear Juergen Beisert, > Replace the individual register access by a few shared access function to > make the code easier to read and in order to add the i.MX23 SoC in the > next step. > > Signed-off-by: Juergen Beisert > CC: linux-arm-ker...@lists.infradead.org > CC: de...@driverdev.osuosl.org >

Re: [PATCH 3/6] Staging/iio/adc/touchscreen/MXS: simplify register access

2013-09-16 Thread Jürgen Beisert
Hi Jonathan, On Sunday 15 September 2013 12:35:29 Jonathan Cameron wrote: > [...] > > +static void mxs_lradc_reg_set(struct mxs_lradc *lradc, u32 val, u32 reg) > > +{ > > + writel(val, lradc->base + reg + STMP_OFFSET_REG_SET); > > +} > > + > > +static void mxs_lradc_reg_clear(struct mxs_lradc *l

Re: [PATCH 3/6] Staging/iio/adc/touchscreen/MXS: simplify register access

2013-09-15 Thread Jonathan Cameron
On 09/11/13 09:18, Juergen Beisert wrote: > Replace the individual register access by a few shared access function to > make the > code easier to read and in order to add the i.MX23 SoC in the next step. > > Signed-off-by: Juergen Beisert > CC: linux-arm-ker...@lists.infradead.org > CC: de...@dr

[PATCH 3/6] Staging/iio/adc/touchscreen/MXS: simplify register access

2013-09-11 Thread Juergen Beisert
Replace the individual register access by a few shared access function to make the code easier to read and in order to add the i.MX23 SoC in the next step. Signed-off-by: Juergen Beisert CC: linux-arm-ker...@lists.infradead.org CC: de...@driverdev.osuosl.org CC: Marek Vasut CC: Fabio Estevam C