Re: [Outreachy kernel] [PATCH 3/3] staging: rtl8192u: Prefer using the BIT macro

2017-02-16 Thread Julia Lawall
On Fri, 17 Feb 2017, simran singhal wrote: > This is a nonfunctional change, declare register bit values with BIT() > helper macro. > > Fix the checkpatch.pl issue: > CHECK: Prefer using the BIT macro replacing > bit shifting on 1 with the BIT(x) macro. > > The BIT() macro will make all the cons

[PATCH 3/3] staging: rtl8192u: Prefer using the BIT macro

2017-02-16 Thread simran singhal
This is a nonfunctional change, declare register bit values with BIT() helper macro. Fix the checkpatch.pl issue: CHECK: Prefer using the BIT macro replacing bit shifting on 1 with the BIT(x) macro. The BIT() macro will make all the constants explicitly 'unsigned', which helps to avoid the warnin