Re: [PATCH 3/3] staging: iio: ad7780: Add parentheses to macros

2019-03-21 Thread Vladimir Petrigo
On Wed, Mar 20, 2019 at 10:42:17AM +0300, Dan Carpenter wrote: > On Sun, Mar 17, 2019 at 11:53:12PM +0300, Vladimir Petrigo wrote: > > - Fix CHECK Macro argument 'wordsize' may be better as '(wordsize)' to > > avoid precedence issues > > - Fix CHECK Macro argument reuse 'bits' - possible side-effe

Re: [PATCH 3/3] staging: iio: ad7780: Add parentheses to macros

2019-03-20 Thread Dan Carpenter
On Sun, Mar 17, 2019 at 11:53:12PM +0300, Vladimir Petrigo wrote: > - Fix CHECK Macro argument 'wordsize' may be better as '(wordsize)' to avoid > precedence issues > - Fix CHECK Macro argument reuse 'bits' - possible side-effects? > > Signed-off-by: Vladimir Petrigo > --- > drivers/staging/iio

[PATCH 3/3] staging: iio: ad7780: Add parentheses to macros

2019-03-17 Thread Vladimir Petrigo
- Fix CHECK Macro argument 'wordsize' may be better as '(wordsize)' to avoid precedence issues - Fix CHECK Macro argument reuse 'bits' - possible side-effects? Signed-off-by: Vladimir Petrigo --- drivers/staging/iio/adc/ad7780.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git