Re: [PATCH 2/7] staging: sm750fb: remove needless goto statements and lables

2015-11-04 Thread Mike Rapoport
On Wed, Nov 04, 2015 at 12:50:30PM +0530, Sudip Mukherjee wrote: > On Sun, Nov 01, 2015 at 10:55:48AM +0200, Mike Rapoport wrote: > > In lynxfb_pci_probe return error immediately in cases no cleanup is > > required. > > > > Signed-off-by: Mike Rapoport > > --- > > NACK. > It should be: > > diff

Re: [PATCH 2/7] staging: sm750fb: remove needless goto statements and lables

2015-11-03 Thread Sudip Mukherjee
On Sun, Nov 01, 2015 at 10:55:48AM +0200, Mike Rapoport wrote: > In lynxfb_pci_probe return error immediately in cases no cleanup is > required. > > Signed-off-by: Mike Rapoport > --- NACK. It should be: diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index c78421

[PATCH 2/7] staging: sm750fb: remove needless goto statements and lables

2015-11-01 Thread Mike Rapoport
In lynxfb_pci_probe return error immediately in cases no cleanup is required. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index c78421b