Re: [PATCH 2/7] iio: light: tsl2583: change functions to only have a single exit point

2016-10-19 Thread Dan Carpenter
On Wed, Oct 19, 2016 at 08:38:16AM -0400, Brian Masney wrote: > On Wed, Oct 19, 2016 at 02:08:59PM +0300, Dan Carpenter wrote: > > On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote: > > > Change the following functions to only have a single exit point: > > > taos_i2c_read(), taos_als_cal

Re: [PATCH 2/7] iio: light: tsl2583: change functions to only have a single exit point

2016-10-19 Thread Brian Masney
On Wed, Oct 19, 2016 at 02:08:59PM +0300, Dan Carpenter wrote: > On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote: > > Change the following functions to only have a single exit point: > > taos_i2c_read(), taos_als_calibrate(), taos_chip_on(), > > taos_gain_store(), taos_gain_available_s

Re: [PATCH 2/7] iio: light: tsl2583: change functions to only have a single exit point

2016-10-19 Thread Dan Carpenter
On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote: > Change the following functions to only have a single exit point: > taos_i2c_read(), taos_als_calibrate(), taos_chip_on(), > taos_gain_store(), taos_gain_available_show(), taos_luxtable_store() > and taos_probe(). > What's the point o

[PATCH 2/7] iio: light: tsl2583: change functions to only have a single exit point

2016-10-19 Thread Brian Masney
Change the following functions to only have a single exit point: taos_i2c_read(), taos_als_calibrate(), taos_chip_on(), taos_gain_store(), taos_gain_available_show(), taos_luxtable_store() and taos_probe(). Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 96