Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-11-04 Thread Laurent Pinchart
Hi Hans, On Monday 04 November 2013 09:34:49 Hans Verkuil wrote: > On 11/04/2013 12:28 AM, Laurent Pinchart wrote: > > On Thursday 03 October 2013 08:54:19 Hans Verkuil wrote: > >> On 10/03/2013 01:55 AM, Laurent Pinchart wrote: > >>> From: Sergio Aguirre > >>> > >>> This adds a very simplistic

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-11-04 Thread Hans Verkuil
On 11/04/2013 12:28 AM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the review. > > On Thursday 03 October 2013 08:54:19 Hans Verkuil wrote: >> On 10/03/2013 01:55 AM, Laurent Pinchart wrote: >>> From: Sergio Aguirre >>> >>> This adds a very simplistic driver to utilize the CSI2A interf

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-11-03 Thread Laurent Pinchart
Hi Dan, Thank you for the comments. On Friday 04 October 2013 11:16:38 Dan Carpenter wrote: > On Thu, Oct 03, 2013 at 01:55:29AM +0200, Laurent Pinchart wrote: > > + > > + ret = vb2_streamon(&vfh->queue, type); > > + if (ret < 0) > > + goto err_iss_video_check_format; > > + > > +

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-11-03 Thread Laurent Pinchart
Hi Hans, Thank you for the review. On Thursday 03 October 2013 08:54:19 Hans Verkuil wrote: > On 10/03/2013 01:55 AM, Laurent Pinchart wrote: > > From: Sergio Aguirre > > > > This adds a very simplistic driver to utilize the CSI2A interface inside > > the ISS subsystem in OMAP4, and dump the da

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-10-04 Thread Dan Carpenter
On Thu, Oct 03, 2013 at 01:55:29AM +0200, Laurent Pinchart wrote: > + > + ret = vb2_streamon(&vfh->queue, type); > + if (ret < 0) > + goto err_iss_video_check_format; > + > + /* In sensor-to-memory mode, the stream can be started synchronously > + * to the stream on com

Re: [PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-10-02 Thread Hans Verkuil
On 10/03/2013 01:55 AM, Laurent Pinchart wrote: > From: Sergio Aguirre > > This adds a very simplistic driver to utilize the CSI2A interface inside > the ISS subsystem in OMAP4, and dump the data to memory. > > Check Documentation/video4linux/omap4_camera.txt for details. > > This commit adds v

[PATCH 2/6] v4l: omap4iss: Add support for OMAP4 camera interface - Video devices

2013-10-02 Thread Laurent Pinchart
From: Sergio Aguirre This adds a very simplistic driver to utilize the CSI2A interface inside the ISS subsystem in OMAP4, and dump the data to memory. Check Documentation/video4linux/omap4_camera.txt for details. This commit adds video devices support. Signed-off-by: Sergio Aguirre [Port the