Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc

2017-03-16 Thread Tobin C. Harding
On Thu, Mar 16, 2017 at 02:29:04PM +0300, Dan Carpenter wrote: > On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote: > > On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote: > > > Code uses identifiers retval, ret, and rc all for function return > > > values. It would b

Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc

2017-03-16 Thread Dan Carpenter
On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote: > On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote: > > Code uses identifiers retval, ret, and rc all for function return > > values. It would be more readable if the whole driver used a single > > identifier for th

Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc

2017-03-15 Thread Tobin C. Harding
On Thu, Mar 16, 2017 at 11:40:47AM +0900, Greg Kroah-Hartman wrote: > On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote: > > Code uses identifiers retval, ret, and rc all for function return > > values. It would be more readable if the whole driver used a single > > identifier for th

Re: [PATCH 2/6] staging: ks7010: replace identifier retval with rc

2017-03-15 Thread Greg Kroah-Hartman
On Tue, Mar 14, 2017 at 09:20:13PM +1100, Tobin C. Harding wrote: > Code uses identifiers retval, ret, and rc all for function return > values. It would be more readable if the whole driver used a single > identifier for this task. Lets use 'rc' since it is the shortest. > > Change retval -> rc I

[PATCH 2/6] staging: ks7010: replace identifier retval with rc

2017-03-14 Thread Tobin C. Harding
Code uses identifiers retval, ret, and rc all for function return values. It would be more readable if the whole driver used a single identifier for this task. Lets use 'rc' since it is the shortest. Change retval -> rc Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks7010_sdio.c |