Hi,
On 2018/9/3 9:59, Chao Yu wrote:
> On 2018/8/31 17:41, Dan Carpenter wrote:
>> On Fri, Aug 31, 2018 at 11:29:03AM +0800, Chao Yu wrote:
>>>
>>> Hi Xiang,
>>>
>>> I'm not against this change which follows checkpatch's rule, since I think
>>> this
>>> can help to unify coding style in different
On 2018/8/31 17:41, Dan Carpenter wrote:
> On Fri, Aug 31, 2018 at 11:29:03AM +0800, Chao Yu wrote:
>>
>> Hi Xiang,
>>
>> I'm not against this change which follows checkpatch's rule, since I think
>> this
>> can help to unify coding style in different modules of Linux. Maybe cleanup
>> in
>> othe
On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
> This patch does not change the logic, it only
> corrects the formatting and checkpatch checks by
> to NULL comparison.
>
> The patch fixes 5 checks of type:
> "Comparison to NULL could be written".
>
> Signed-off-by: Pavel Zemlyanoy
Reviewed-by: Chao
On Fri, Aug 31, 2018 at 11:29:03AM +0800, Chao Yu wrote:
>
> Hi Xiang,
>
> I'm not against this change which follows checkpatch's rule, since I think
> this
> can help to unify coding style in different modules of Linux. Maybe cleanup in
> other filesystem is needed as well.
>
That code is old
On 2018/8/31 0:32, Gao Xiang via Linux-erofs wrote:
>
>
> On 2018/8/31 0:09, Gao Xiang via Linux-erofs wrote:
>> Hi Pavel,
>>
>> On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
>>> This patch does not change the logic, it only
>>> corrects the formatting and checkpatch checks by
>>> to NULL comparison
On 2018/8/31 0:09, Gao Xiang via Linux-erofs wrote:
> Hi Pavel,
>
> On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
>> This patch does not change the logic, it only
>> corrects the formatting and checkpatch checks by
>> to NULL comparison.
>>
>> The patch fixes 5 checks of type:
>> "Comparison to NU
Hi Pavel,
On 2018/8/30 23:13, Pavel Zemlyanoy wrote:
> This patch does not change the logic, it only
> corrects the formatting and checkpatch checks by
> to NULL comparison.
>
> The patch fixes 5 checks of type:
> "Comparison to NULL could be written".
>
> Signed-off-by: Pavel Zemlyanoy
Sorry
This patch does not change the logic, it only
corrects the formatting and checkpatch checks by
to NULL comparison.
The patch fixes 5 checks of type:
"Comparison to NULL could be written".
Signed-off-by: Pavel Zemlyanoy
---
drivers/staging/erofs/unzip_vle_lz4.c | 10 +-
1 file changed, 5