Re: [PATCH 2/3] vme_user: Update API to work in mixed environments

2013-12-03 Thread Dan Carpenter
Also use the __packed macro. struc vme_master { ... } __packed; regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 2/3] vme_user: Update API to work in mixed environments

2013-12-03 Thread Aaron Sierra
- Original Message - > From: "Greg Kroah-Hartman" > Sent: Tuesday, December 3, 2013 1:07:51 PM > [snip] > > > > diff --git a/drivers/staging/vme/devices/vme_user.h > > b/drivers/staging/vme/devices/vme_user.h > > index 7d24cd6..6726a42 100644 > > --- a/drivers/staging/vme/devices/vme_

Re: [PATCH 2/3] vme_user: Update API to work in mixed environments

2013-12-03 Thread Greg Kroah-Hartman
On Thu, Oct 31, 2013 at 06:47:54PM -0500, Aaron Sierra wrote: > This patch updates the vme_master and vme_slave structures to use > types with well defined size and to prevent the compiler from > inserting padding (between enable and vme_addr for one). > > The original vme_master and vme_slave str

Re: [PATCH 2/3] vme_user: Update API to work in mixed environments

2013-11-05 Thread Greg Kroah-Hartman
On Tue, Nov 05, 2013 at 05:01:10PM +, Martyn Welch wrote: > Greg - I don't have any experience dealing with a mixture of 32-bit user space > and a 64-bit kernel, is this the correct thing to do? It might be, we need to do something here. I'll review it when I get through my patch queue, hopef

Re: [PATCH 2/3] vme_user: Update API to work in mixed environments

2013-11-05 Thread Martyn Welch
Greg - I don't have any experience dealing with a mixture of 32-bit user space and a 64-bit kernel, is this the correct thing to do? On 31/10/13 23:47, Aaron Sierra wrote: > This patch updates the vme_master and vme_slave structures to use > types with well defined size and to prevent the compiler

[PATCH 2/3] vme_user: Update API to work in mixed environments

2013-10-31 Thread Aaron Sierra
This patch updates the vme_master and vme_slave structures to use types with well defined size and to prevent the compiler from inserting padding (between enable and vme_addr for one). The original vme_master and vme_slave structs would be different sizes and have different layouts depending on wh