Re: [PATCH 2/3] staging: lustre: fix pointer whitespace style

2014-09-08 Thread Joe Perches
On Mon, 2014-09-08 at 13:32 +0300, Dan Carpenter wrote: > On Sat, Sep 06, 2014 at 11:19:03AM -0700, Joe Perches wrote: > > Indexing a string array with an enum is generally unsafe. > > I think it better to use a switch/case like: > The reverse side of that argument is that switch statements are slo

Re: [PATCH 2/3] staging: lustre: fix pointer whitespace style

2014-09-08 Thread Dan Carpenter
On Sat, Sep 06, 2014 at 11:19:03AM -0700, Joe Perches wrote: > > Indexing a string array with an enum is generally unsafe. > > I think it better to use a switch/case like: > The reverse side of that argument is that switch statements are slower and uglier. My understanding is that according to

Re: [PATCH 2/3] staging: lustre: fix pointer whitespace style

2014-09-06 Thread Joe Perches
On Sat, 2014-09-06 at 13:38 -0400, Spencer Baugh wrote: > Fix errors reported by checkpatch of this kind: [] > diff --git a/drivers/staging/lustre/lustre/include/lustre_import.h > b/drivers/staging/lustre/lustre/include/lustre_import.h [] > @@ -103,9 +103,9 @@ enum lustre_imp_state { > }; > >

[PATCH 2/3] staging: lustre: fix pointer whitespace style

2014-09-06 Thread Spencer Baugh
Fix errors reported by checkpatch of this kind: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Spencer Baugh --- drivers/staging/lustre/lustre/include/lustre_import.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lustre_impo