Re: [PATCH 2/3] iio: make use of iio_device_attach_kfifo_buffer() where straightforward

2020-04-07 Thread Ardelean, Alexandru
On Tue, 2020-04-07 at 11:26 +0200, Markus Elfring wrote: > [External] > > How do you think about a patch subject like “iio: Increase use of > iio_device_attach_kfifo_buffer()”? > > > > This change does that. > > I suggest to improve also this commit message. > > * Would you like to consider a

Re: [PATCH 2/3] iio: make use of iio_device_attach_kfifo_buffer() where straightforward

2020-04-07 Thread Markus Elfring
How do you think about a patch subject like “iio: Increase use of iio_device_attach_kfifo_buffer()”? > This change does that. I suggest to improve also this commit message. * Would you like to consider a wording like “Convert a specific function call combination to a better programming inter

Re: [PATCH 2/3] iio: make use of iio_device_attach_kfifo_buffer() where straightforward

2020-04-05 Thread Jonathan Cameron
On Wed, 1 Apr 2020 15:59:35 +0300 Alexandru Ardelean wrote: > All drivers that already call devm_iio_kfifo_allocate() & > iio_device_attach_buffer() are simple to convert to > iio_device_attach_kfifo_buffer() in a single go/patch/. > > This change does that. > > For drivers max30100 & max30102

[PATCH 2/3] iio: make use of iio_device_attach_kfifo_buffer() where straightforward

2020-04-01 Thread Alexandru Ardelean
All drivers that already call devm_iio_kfifo_allocate() & iio_device_attach_buffer() are simple to convert to iio_device_attach_kfifo_buffer() in a single go/patch/. This change does that. For drivers max30100 & max30102 this helper is called after indio_dev has been populated. This doesn't make