Re: [PATCH 2/3] binder: read pre-translated fds from sender buffer

2021-11-24 Thread Dan Carpenter
On Wed, Nov 24, 2021 at 12:33:20PM -0800, Todd Kjos wrote: > I agree -- if copy_from_user() for some reason doesn't copy the whole > buffer, it might return a positive integer. Then it would skip > binder_translate_fd(), but not return. That should probably be > something like: > > if (ret) >

Re: [PATCH 2/3] binder: read pre-translated fds from sender buffer

2021-11-24 Thread Dan Carpenter
On Tue, Nov 23, 2021 at 11:17:36AM -0800, Todd Kjos wrote: > Since we are no longer going to copy the pre-fixup > data from the target buffer, we need to read > pre-translated FD array information from the source > buffer. > The commit message is really misleading. From the commit message it sou