Re: [PATCH 2/2] staging: ks7010: remove dead code

2017-03-15 Thread Dan Carpenter
On Wed, Mar 15, 2017 at 09:00:24AM +0100, Wolfram Sang wrote: > On Wed, Mar 15, 2017 at 01:57:32PM +1100, Tobin C. Harding wrote: > > Driver has dead code compiled out using preprocessor directives. TODO > > file asks for these not to be removed - ignore this. > > Why? > I got bored reviewing ch

Re: [PATCH 2/2] staging: ks7010: remove dead code

2017-03-15 Thread Tobin C. Harding
On Wed, Mar 15, 2017 at 09:00:24AM +0100, Wolfram Sang wrote: > On Wed, Mar 15, 2017 at 01:57:32PM +1100, Tobin C. Harding wrote: > > Driver has dead code compiled out using preprocessor directives. TODO > > file asks for these not to be removed - ignore this. > > Why? > It was suggested to me du

Re: [PATCH 2/2] staging: ks7010: remove dead code

2017-03-15 Thread Wolfram Sang
On Wed, Mar 15, 2017 at 01:57:32PM +1100, Tobin C. Harding wrote: > Driver has dead code compiled out using preprocessor directives. TODO > file asks for these not to be removed - ignore this. Why? signature.asc Description: PGP signature ___ devel ma

[PATCH 2/2] staging: ks7010: remove dead code

2017-03-14 Thread Tobin C. Harding
Driver has dead code compiled out using preprocessor directives. TODO file asks for these not to be removed - ignore this. Remove dead code. Remove 'do not remove #if 0/1 ...' from TODO file. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/TODO | 2 - drivers/staging/ks701