Re: [PATCH 2/2] staging: gdm724x: Remove variable

2019-05-25 Thread Sven Van Asbroeck
On Fri, May 24, 2019 at 2:04 AM Nishka Dasgupta wrote: > > The return variable is used only twice (in two different branches), and > both times it is assigned the same constant value. These can therefore > be merged into the same assignment, placed at the point that both > these branches (and no o

Re: [PATCH 2/2] staging: gdm724x: Remove variable

2019-05-23 Thread Greg KH
On Fri, May 24, 2019 at 11:30:26AM +0530, Nishka Dasgupta wrote: > The return variable is used only twice (in two different branches), and > both times it is assigned the same constant value. These can therefore > be merged into the same assignment, placed at the point that both > these branches (a

[PATCH 2/2] staging: gdm724x: Remove variable

2019-05-23 Thread Nishka Dasgupta
The return variable is used only twice (in two different branches), and both times it is assigned the same constant value. These can therefore be merged into the same assignment, placed at the point that both these branches (and no other) go to. The return variable itself can be removed. Issue foun