Re: [PATCH 2/2] staging: dgnc: remove useless spinlock

2015-09-06 Thread Greg KH
On Sat, Sep 05, 2015 at 01:12:02PM +0100, Salah Triki wrote: > dgnc_poll_stop is a local variable in dgnc_driver.c, so it is useless to take > dgnc_poll_lock before > accessing to this variable. No, not at all! scope doesn't matter for locks, this patch is broken and wrong. How did you test it?

[PATCH 2/2] staging: dgnc: remove useless spinlock

2015-09-05 Thread Salah Triki
dgnc_poll_stop is a local variable in dgnc_driver.c, so it is useless to take dgnc_poll_lock before accessing to this variable. Signed-off-by: Salah Triki --- drivers/staging/dgnc/dgnc_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/s