Re: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 11:57 -0500, Larry Finger wrote: > The entries in this enum may be referenced in debug output. Adding explicit > values simplifies the lookup. A negative aspect to this style is forced renumbering if a HW_VAR entry is inserted. Is that possible?

Re: [PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum

2016-09-24 Thread Larry Finger
On 09/24/2016 12:43 PM, Joe Perches wrote: On Sat, 2016-09-24 at 11:57 -0500, Larry Finger wrote: The entries in this enum may be referenced in debug output. Adding explicit values simplifies the lookup. A negative aspect to this style is forced renumbering if a HW_VAR entry is inserted. Is t

[PATCH 2/2] rtlwifi: Add explicit values to hw_variables enum

2016-09-24 Thread Larry Finger
The entries in this enum may be referenced in debug output. Adding explicit values simplifies the lookup. Signed-off-by: Larry Finger --- drivers/net/wireless/realtek/rtlwifi/wifi.h | 208 ++-- 1 file changed, 104 insertions(+), 104 deletions(-) diff --git a/drivers/net/