Re: [PATCH 19/19] Add in-kernel firmware loading support

2014-02-20 Thread Dan Carpenter
On Wed, Feb 19, 2014 at 04:01:59PM -0500, Mark Hounschell wrote: > OK, thanks Dan. I'll followup with a new 19/19 patch. It did compile and > work with no complaints about the above though. I should have checked > that last one better as it is > new code added. > No worries. This is the review

Re: [PATCH 19/19] Add in-kernel firmware loading support

2014-02-19 Thread Mark Hounschell
On 02/19/2014 03:17 PM, Dan Carpenter wrote: > This one has white space problems. Run scripts/checkpatch.pl on your > patches before sending. Comments below. > > On Wed, Feb 19, 2014 at 01:12:15PM -0500, Mark Hounschell wrote: >> +static int dgap_firmware_load(struct pci_dev *pdev, int card_type

Re: [PATCH 19/19] Add in-kernel firmware loading support

2014-02-19 Thread Dan Carpenter
This one has white space problems. Run scripts/checkpatch.pl on your patches before sending. Comments below. On Wed, Feb 19, 2014 at 01:12:15PM -0500, Mark Hounschell wrote: > +static int dgap_firmware_load(struct pci_dev *pdev, int card_type) > +{ > + struct board_t *brd = dgap_Board[dgap_N

[PATCH 19/19] Add in-kernel firmware loading support

2014-02-19 Thread Mark Hounschell
This patch adds in-kernel firmware loading support and removes support for the original userland firmware loading process. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 540 +++- 1 file changed, 338 insertions(+),